support for colon form of :param command.

Author: praveenag

cypher-shell/src/integration-test/java/org/neo4j/shell/commands/CypherShellIntegrationTest.java

@@ -162,7 +162,7 @@ public void commitScenario() throws CommandException {
     }
 
     @Test
-    public void setAndListVariables() throws CommandException {
+    public void paramsAndListVariables() throws CommandException {
         assertTrue(shell.getAll().isEmpty());
 
         long randomLong = System.currentTimeMillis();

cypher-shell/src/main/java/org/neo4j/shell/commands/Param.java

@@ -16,7 +16,7 @@
  */
 public class Param implements Command {
     // Match arguments such as "(key) (value with possible spaces)" where key and value are any strings
-    private static final Pattern argPattern = Pattern.compile("^\\s*(?<key>[^\\s]+)\\s+(?<value>.+)$");
+    private static final Pattern argPattern = Pattern.compile("^\\s*(?<key>.+?):?\\s+(?<value>.+)$");
     public static final String COMMAND_NAME = ":param";
     private final VariableHolder variableHolder;
 

cypher-shell/src/test/java/org/neo4j/shell/commands/ParamTest.java

@@ -50,12 +50,34 @@ public void setValue() throws CommandException {
         verify(mockShell).set("bob", "9");
     }
 
+    @Test
+    public void setValueWithSpecialCharacters() throws CommandException {
+        cmd.execute("bob#   9");
+
+        verify(mockShell).set("bob#", "9");
+    }
+
     @Test
     public void shouldNotSplitOnSpace() throws CommandException {
         cmd.execute("bob 'one two'");
         verify(mockShell).set("bob", "'one two'");
     }
 
+    @Test
+    public void shouldAcceptColonFormOfParams() throws CommandException {
+        cmd.execute("bob: one");
+        verify(mockShell).set("bob", "one");
+    }
+
+    @Test
+    public void shouldAcceptForTwoColonsFormOfParams() throws CommandException {
+        cmd.execute("bob:: one");
+        verify(mockShell).set("bob:", "one");
+
+        cmd.execute("t:om two");
+        verify(mockShell).set("t:om", "two");
+    }
+
     @Test
     public void shouldNotExecuteEscapedCypher() throws CommandException {
         cmd.execute("bob \"RETURN 5 as bob\"");