[Testing] Make a few more examples testable (#499)

I removed a few `test-skip` here and there, and removed some useless
attributes from code blocks where I was editing already.
Also added some comments on why some examples need to be skipped.

Author: stefano-ottolenghi

modules/ROOT/pages/administration/access-control/built-in-roles.adoc

@@ -453,8 +453,7 @@ To restore the role to its original capabilities two steps are needed.
 First, execute `DROP ROLE admin`.
 Secondly, run these queries:
 
-// we cannot test this right now cause we would delete the role the test user is logged with
-
+// cannot test as it would require deleting the role the test user is logged with
 [source, cypher, role=noplay test-skip]
 ----
 CREATE ROLE admin

modules/ROOT/pages/administration/access-control/manage-users.adoc

@@ -817,6 +817,7 @@ Users can change their password using `ALTER CURRENT USER SET PASSWORD`.
 The old password is required in addition to the new one, and either or both can be a string value or a string parameter.
 When a user executes this command it will change their password as well as set the `CHANGE NOT REQUIRED` flag.
 
+// can't test, don't want to hardcode test user password
 [source, cypher, role=test-skip]
 ----
 ALTER CURRENT USER

modules/ROOT/pages/clauses/merge.adoc

@@ -7,7 +7,7 @@
 == Introduction
 
 The `MERGE` clause either matches existing node patterns in the graph and binds them or, if not present, creates new data and binds that.
-In this way, it acts as a combination of `MATCH` and `CREATE` that allows for specific actions depending on whether the specified data was matched or created. 
+In this way, it acts as a combination of `MATCH` and `CREATE` that allows for specific actions depending on whether the specified data was matched or created.
 
 For example, `MERGE` can be used to specify that a graph must contain a node with a `Person` label and a specific `name` property.
 If there isn't a node with the specific `name` property, a new node will be created with that `name` property.
@@ -80,7 +80,7 @@ RETURN robert, labels(robert)
 A new node is created because there are no nodes labeled `Critic` in the database:
 
 .Result
-[role="queryresult",options="header,footer",cols="2*<m"]
+[role="queryresult",options="header",cols="2*<m"]
 |===
 | +robert+ | +labels(robert)+
 | +{}+ | +["Critic"]+
@@ -90,7 +90,7 @@ A new node is created because there are no nodes labeled `Critic` in the databas
 [[merge-merge-single-node-with-properties]]
 === Merge single node with properties
 
-Merging a node with properties that differ from the properties on existing nodes in the graph will create a new node: 
+Merging a node with properties that differ from the properties on existing nodes in the graph will create a new node:
 
 .Query
 [source, cypher]
@@ -102,7 +102,7 @@ RETURN charlie
 A new node with the name `'Charlie Sheen'` is created since not all properties matched those set to the pre-existing `'Charlie Sheen'` node:
 
 .Result
-[role="queryresult",options="header,footer",cols="1*<m"]
+[role="queryresult",options="header",cols="1*<m"]
 |===
 | +charlie+
 | +{"name":"Charlie Sheen","age":10}+
@@ -124,7 +124,7 @@ RETURN michael.name, michael.bornIn
 `'Michael Douglas'` is matched and the `name` and `bornIn` properties are returned:
 
 .Result
-[role="queryresult",options="header,footer",cols="2*<m"]
+[role="queryresult",options="header",cols="2*<m"]
 |===
 | +michael.name+ | +michael.bornIn+
 | +"Michael Douglas"+ | +"New Jersey"+
@@ -149,7 +149,7 @@ As the `'New York'` node is not matched for the first bound node, it is created.
 However, the newly-created `'New York'` node is matched and bound for the second and third bound nodes.
 
 .Result
-[role="queryresult",options="header,footer",cols="3*<m"]
+[role="queryresult",options="header",cols="3*<m"]
 |===
 | +person.name+ | +person.bornIn+ | +location+
 | +"Charlie Sheen"+ | +"New York"+ | +{name:"New York"}+
@@ -181,7 +181,7 @@ The query creates the `Person` node named `Keanu Reeves`, with a `bornIn` proper
 It also sets a timestamp for the `created` property.
 
 .Result
-[role="queryresult",options="header,footer",cols="2*<m"]
+[role="queryresult",options="header",cols="2*<m"]
 |===
 | +keanu.name+ | +keanu.created+
 | +"Keanu Reeves"+ | +1655200898563+
@@ -205,7 +205,7 @@ RETURN person.name, person.found
 The query finds all the `Person` nodes, sets a property on them, and returns them:
 
 .Result
-[role="queryresult",options="header,footer",cols="2*<m"]
+[role="queryresult",options="header",cols="2*<m"]
 |===
 | +person.name+ | +person.found+
 | +"Charlie Sheen"+ | +true+
@@ -235,7 +235,7 @@ Because the `Person` node named `Keanu Reeves` already exists, this query does n
 Instead, it adds a timestamp on the `lastSeen` property.
 
 .Result
-[role="queryresult",options="header,footer",cols="3*<m"]
+[role="queryresult",options="header",cols="3*<m"]
 |===
 | +keanu.name+ | +keanu.created+ | +keanu.lastSeen+
 | +"Keanu Reeves"+ | +1655200902354+ | +1674655352124+
@@ -259,7 +259,7 @@ RETURN person.name, person.found, person.lastAccessed
 ----
 
 .Result
-[role="queryresult",options="header,footer",cols="3*<m"]
+[role="queryresult",options="header",cols="3*<m"]
 |===
 | +person.name+ | +person.found+ | +person.lastAccessed+
 | +"Charlie Sheen"+ | +true+ | +1655200903558+
@@ -293,7 +293,7 @@ RETURN charlie.name, type(r), wallStreet.title
 Note that in order to match or create a relationship when using `MERGE`, at least one bound node must be specified, which is done via the `MATCH` clause in the above example.
 
 .Result
-[role="queryresult",options="header,footer",cols="3*<m"]
+[role="queryresult",options="header",cols="3*<m"]
 |===
 | +charlie.name+ | +type(r)+ | +wallStreet.title+
 | +"Charlie Sheen"+ | +"ACTED_IN"+ | +"Wall Street"+
@@ -318,7 +318,7 @@ When trying to `MERGE` a `Movie` node between them, Neo4j will not use any of th
 Instead, a new `Movie` node is created.
 
 .Result
-[role="queryresult",options="header,footer",cols="1*<m"]
+[role="queryresult",options="header",cols="1*<m"]
 |===
 | +movie+
 | +{}+
@@ -345,7 +345,7 @@ As `'Charlie Sheen'` and `'Oliver Stone'` do not know each other in the example
 The direction of the created relationship is arbitrary.
 
 .Result
-[role="queryresult",options="header,footer",cols="1*<m"]
+[role="queryresult",options="header",cols="1*<m"]
 |===
 | +r+
 | +{}+
@@ -371,7 +371,7 @@ The second `MERGE` creates a `BORN_IN` relationship between each person and a lo
 `'Charlie Sheen'`, `'Rob Reiner',` and `'Oliver Stone'` all have a `BORN_IN` relationship to the _same_ `Location` node (`'New York'`).
 
 .Result
-[role="queryresult",options="header,footer",cols="3*<m"]
+[role="queryresult",options="header",cols="3*<m"]
 |===
 | +person.name+ | +person.bornIn+ | +location+
 | +"Charlie Sheen"+ | +"New York"+ | +{name:"New York"}+
@@ -402,7 +402,7 @@ As `'Charlie Sheen'` and `'Michael Douglas'` both have a chauffeur with the same
 This is in contrast to the example shown above in xref::clauses/merge.adoc#merge-merge-on-a-relationship-between-two-existing-nodes[Merge on a relationship between two existing nodes], where the first `MERGE` was used to bind the `Location` nodes and to prevent them from being recreated (and thus duplicated) on the second `MERGE`.
 
 .Result
-[role="queryresult",options="header,footer",cols="3*<m"]
+[role="queryresult",options="header",cols="3*<m"]
 |===
 | +person.name+ | +person.chauffeurName+ | +chauffeur+
 | +"Charlie Sheen"+ | +"John Brown"+ | +{name:"John Brown"}+
@@ -446,7 +446,7 @@ RETURN laurence.name
 ----
 
 .Result
-[role="queryresult",options="header,footer",cols="1*<m"]
+[role="queryresult",options="header",cols="1*<m"]
 |===
 | +laurence.name+
 | +"Laurence Fishburne"+
@@ -466,7 +466,7 @@ RETURN oliver.name, oliver.bornIn
 ----
 
 .Result
-[role="queryresult",options="header,footer",cols="2*<m"]
+[role="queryresult",options="header",cols="2*<m"]
 |===
 | +oliver.name+ | +oliver.bornIn+
 | +"Oliver Stone"+ | +"New York"+
@@ -534,27 +534,28 @@ To use map parameters with `MERGE`, it is necessary to explicitly use the expect
 For more information on parameters, see xref::syntax/parameters.adoc[].
 
 .Parameters
-[source,javascript, indent=0]
+[source, javascript]
 ----
 {
   "param": {
     "name": "Keanu Reeves",
-    "role": "Neo"
+    "bornIn": "Beirut",
+    "chauffeurName": "Eric Brown"
   }
 }
 ----
 
 .Query
-[source, cypher, role=test-skip]
+[source, cypher]
 ----
-MERGE (person:Person {name: $param.name, role: $param.role})
-RETURN person.name, person.role
+MERGE (person:Person {name: $param.name, bornIn: $param.bornIn, chauffeurName: $param.chauffeurName})
+RETURN person.name, person.bornIn, person.chauffeurName
 ----
 
 .Result
-[role="queryresult",options="header,footer",cols="2*<m"]
+[role="queryresult",options="header",cols="3*<m"]
 |===
-| +person.name+ | +person.role+
-| +"Keanu Reeves"+ | +"Neo"+
+| person.name | person.bornIn | person.chauffeurName
+| "Keanu Reeves" | "Beirut" | "Eric Brown"
 |===
 

modules/ROOT/pages/clauses/use.adoc

@@ -55,12 +55,14 @@ When executing queries against a composite database, the `USE` clause must only
 [[query-use-examples]]
 == Examples
 
-To create the database `myDatabase`, run the following query in a Neo4j database: 
+////
 [source, cypher, role=test-setup]
 ----
 CREATE DATABASE myDatabase;
+CREATE COMPOSITE DATABASE `myComposite`;
+CREATE ALIAS `myComposite`.`myConstituent` FOR DATABASE `myDatabase`;
 ----
-
+////
 
 [[query-use-examples-query-graph]]
 === Query a graph
@@ -80,7 +82,7 @@ MATCH (n) RETURN n
 In this example it is assumed that the DBMS contains a composite database named `myComposite`, which includes an alias named `myConstituent`:
 
 .Query
-[source, cypher, role="test-skip"]
+[source, cypher]
 ----
 USE myComposite.myConstituent
 MATCH (n) RETURN n
@@ -95,14 +97,15 @@ The built-in function `graph.byName()` can be used in the `USE` clause to resolv
 This example uses a composite database named `myComposite` that includes an alias named `myConstituent`:
 
 .Query
-[source, cypher, role="test-skip"]
+[source, cypher]
 ----
 USE graph.byName('myComposite.myConstituent')
 MATCH (n) RETURN n
 ----
 
 The argument can be any expression that evaluates to the name of a constituent graph - for example a parameter:
-// this can only run under composite databases
+
+// can't run this through drivers, we need a value when initializing a session
 .Query
 [source, cypher, role=test-skip]
 ----

modules/ROOT/pages/indexes-for-search-performance.adoc

@@ -660,6 +660,7 @@ The index is not immediately available, but is created in the background.
 .+CREATE LOOKUP INDEX+
 ======
 
+// Lookup indexes exist by default, recreating them would raise an error
 .Query
 [source, cypher, role=test-skip]
 ----
@@ -703,6 +704,7 @@ The index is not immediately available, but is created in the background.
 .+CREATE LOOKUP INDEX+
 ======
 
+// Lookup indexes exist by default, recreating them would raise an error
 .Query
 [source, cypher, role=test-skip]
 ----
@@ -746,6 +748,7 @@ Only one valid value exists for the index provider, `token-lookup-1.0`, which is
 .+CREATE LOOKUP INDEX+
 ======
 
+// Lookup indexes exist by default, recreating them would raise an error
 .Query
 [source, cypher, role=test-skip]
 ----

modules/ROOT/pages/introduction/cypher_overview.adoc

@@ -2,21 +2,30 @@
 = Overview
 :description: This section provides an overview of Cypher and its key differences compared to SQL.
 
-This section provides an overview of Cypher and a brief discussion of how Cypher differs to SQL. 
+This section provides an overview of Cypher and a brief discussion of how Cypher differs to SQL.
+
+////
+[source, cypher, role=test-setup]
+----
+MERGE (matrix:Movie {title: 'The Matrix', rating: 10})
+MERGE (keanu:Person {name: 'Keanu Reeves'})
+MERGE (keanu)-[:ACTED_IN]->(matrix)
+----
+////
 
 == What is Cypher?
 
-Cypher is Neo4j’s declarative graph query language. 
-It was created in 2011 by Neo4j engineers as an SQL-equivalent language for graph databases.  
+Cypher is Neo4j’s declarative graph query language.
+It was created in 2011 by Neo4j engineers as an SQL-equivalent language for graph databases.
 Similar to SQL, Cypher lets users focus on _what_ to retrieve from graph, rather than _how_ to retrieve it.
 As such, Cypher enables users to realize the full potential of their property graph databases by allowing for efficient and expressive queries that reveal previously unknown data connections and clusters.
 
-Cypher provides a visual way of matching patterns and relationships. 
+Cypher provides a visual way of matching patterns and relationships.
 It relies on the following ascii-art type of syntax:  `(nodes)-[:CONNECT_TO]->(otherNodes)`.
-Rounded brackets are used for circular nodes, and `-[:ARROWS]->` for relationships. 
-Writing a query is effectively like drawing a pattern through the data in the graph. 
+Rounded brackets are used for circular nodes, and `-[:ARROWS]->` for relationships.
+Writing a query is effectively like drawing a pattern through the data in the graph.
 In other words, entities such as nodes and their relationships are visually built into queries.
-This makes Cypher a highly intuitive language to both read and write. 
+This makes Cypher a highly intuitive language to both read and write.
 
 == Cypher and SQL: key differences
 
@@ -27,8 +36,8 @@ However, there are some important differences between the two:
 *Cypher is schema-flexible*::
 
 While it is both possible and advised to enforce partial schemas using xref:constraints/index.adoc[indexes and constraints], Cypher and Neo4j offers a greater degree of schema-flexibility than SQL and a relational database.
-More specifically, nodes and relationships in a Neo4j database do not have to have a specific property set to them because other nodes or relationships in the same graph have that property (unless there is an xref:constraints/examples.adoc#constraints-examples-node-property-existence[existence constraint created on that specific property]). 
-This means that users are not required to use a fixed schema to represent data and that they can add new attributes and relationships as their graphs evolve. 
+More specifically, nodes and relationships in a Neo4j database do not have to have a specific property set to them because other nodes or relationships in the same graph have that property (unless there is an xref:constraints/examples.adoc#constraints-examples-node-property-existence[existence constraint created on that specific property]).
+This means that users are not required to use a fixed schema to represent data and that they can add new attributes and relationships as their graphs evolve.
 
 *Query order*::
 
@@ -41,11 +50,11 @@ FROM movie
 WHERE movie.rating > 7
 ----
 +
-[source, cypher, role=test-skip]
+[source, cypher]
 ----
 MATCH (movie:Movie)
 WHERE movie.rating > 7
-RETURN movie.name
+RETURN movie.title
 ----
 
 *Cypher queries are more concise*::
@@ -62,15 +71,15 @@ FROM actors
 WHERE movies.title = "The Matrix"
 ----
 +
-[source, cypher, role=test-skip]
+[source, cypher]
 ----
 MATCH (actor:Actor)-[:ACTED_IN]->(movie:Movie {title: 'The Matrix'})
 RETURN actor.name
 ----
 
 == Cypher and APOC
 
-Neo4j supports the APOC (Awesome Procedures on Cypher) Core library. 
+Neo4j supports the APOC (Awesome Procedures on Cypher) Core library.
 The APOC Core library provides access to user-defined procedures and functions which extend the use of the Cypher query language into areas such as data integration, graph algorithms, and data conversion.
 
-For more details, visit the link:{neo4j-docs-base-uri}/apoc/{page-version}[APOC Core page]. 
+For more details, visit the link:{neo4j-docs-base-uri}/apoc/{page-version}[APOC Core page].