Clarify CALL subquery ambiguities #1060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPryce-Aklundh
added
the
cherry-pick-this-to-5.x
gem-neo4j
approved these changes
Oct 14, 2024
Contributor
gem-neo4j
left a comment
gem-neo4j
left a comment
There was a problem hiding this comment.
Looks good! Just a few comments :)
| ==== | ||
| This example, which finds the friends of each `Player` and xref:functions/aggregating.adoc#functions-count[counts] the number of friends per player, highlights the difference between using `CALL` and `OPTIONAL CALL`. | ||
| This example, which finds team that each `Player` plays for, highlights the difference between using `CALL` and `OPTIONAL CALL`. |
Contributor
There was a problem hiding this comment.
Suggested change
| This example, which finds team that each `Player` plays for, highlights the difference between using `CALL` and `OPTIONAL CALL`. | |
| This example, which finds the team that each `Player` plays for, highlights the difference between using `CALL` and `OPTIONAL CALL`. |
| |=== | ||
| Note that no results are returned for `Player D`, `Player E`, and `Player F`, since they have no outgoing `FRIEND_OF` relationships connected to them. | ||
| Note that no results are returned for `Player C`, since they have are not connected to any `Team` with a `PLAYS_FOR` relationship. |
Contributor
There was a problem hiding this comment.
Suggested change
| Note that no results are returned for `Player C`, since they have are not connected to any `Team` with a `PLAYS_FOR` relationship. | |
| Note that no results are returned for `Player C`, since they are not connected to any `Team` with a `PLAYS_FOR` relationship. |
| The following example finds the name of each `Player` and the names of their friends. | ||
| No rows are returned for the `Player` nodes without any `FRIEND_OF` relationships, the number of results of the subquery thus changed the number of results of the enclosing query. | ||
| The following example finds the name of each `Player` and the teams they play for. | ||
| No rows are returned for `Player C`, since they have are not connected to a `Team` with a `PLAYS_FOR` relationship. |
Contributor
There was a problem hiding this comment.
Suggested change
| No rows are returned for `Player C`, since they have are not connected to a `Team` with a `PLAYS_FOR` relationship. | |
| No rows are returned for `Player C`, since they are not connected to a `Team` with a `PLAYS_FOR` relationship. |
| | "Player A" | ||
| | "Player C" | ||
| | playerName | team |
Contributor
There was a problem hiding this comment.
Suggested change
| | playerName | team | |
| | player | team |
Collaborator
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
JPryce-Aklundh
added a commit
that referenced
this pull request
Oct 14, 2024
gem-neo4j
pushed a commit
to gem-neo4j/docs-cypher
that referenced
this pull request
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.