From ed2c67e29fa19c8fa3d40a24e3206de222eb21ac Mon Sep 17 00:00:00 2001 From: Mark Dixon <1756429+mnd999@users.noreply.github.com> Date: Mon, 28 Oct 2024 16:43:11 +0000 Subject: [PATCH 1/7] Further deprecations to options in CREATE DATABASE * Deprecate seedCredentials and seedConfig options without a (language) replacement. * Deprecate standard and high_limit store formats. --- ...ions-additions-removals-compatibility.adoc | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc b/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc index e161d05f1..e6d738804 100644 --- a/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc +++ b/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc @@ -38,6 +38,28 @@ a| The column `propertyTypes` currently returned by the procedures link:{neo4j-docs-base-uri}/operations-manual/{page-version}/procedures/#procedure_db_schema_nodetypeproperties[`db.schema.nodeTypeProperties()`] and link:{neo4j-docs-base-uri}/operations-manual/{page-version}/procedures/#procedure_db_schema_reltypeproperties[`db.schema.relTypeProperties()`] produces a list of strings representing the potential Java types for a given property. In an upcoming major release of Neo4j, this will be updated to represent the possible Cypher types for that property instead. For all available Cypher types, see the section on xref::values-and-types/property-structural-constructed.adoc#types-synonyms[types and their synonyms]. + +a| +label:functionality[] +label:deprecated[] +[source, cypher, role="noheader"] +---- +CREATE DATABASE db OPTIONS { seedCredentials: ..., seedConfig: ... } +---- +| The `CREATE DATABASE` options `seedCredentials` and `seedConfig` have been deprecated. S3 credentials and configuration are now read by the S3 client +from one of the normal locations, for example the executing users credentials in `$HOME/.aws/credentials`. For further infomation see .... + +a| +label:functionality[] +label:deprecated[] +[source, cypher, role="noheader"] +---- +CREATE DATABASE db OPTIONS { storeFormat: 'standard' } + +CREATE DATABASE db OPTIONS { storeFormat: 'high_limit' } +---- +| The standard and high_limit store formats have been deprecated. Creating databases with these formats is therefore also deprecated. +For more information on the deprecation of these formats, see link:{neo4j-docs-base-uri}/operations-manual/{page-version}/database-internals/store-formats/#format-deprecations[Format deprecations] |=== [[cypher-deprecations-additions-removals-5.25]] From 5922f1bdb4056b4a408f54cc5313b2ee1e4e8863 Mon Sep 17 00:00:00 2001 From: Mark Dixon <1756429+mnd999@users.noreply.github.com> Date: Wed, 30 Oct 2024 10:39:45 +0000 Subject: [PATCH 2/7] Update to link back to clustering docs --- .../pages/deprecations-additions-removals-compatibility.adoc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc b/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc index e6d738804..8d109defb 100644 --- a/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc +++ b/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc @@ -46,8 +46,7 @@ label:deprecated[] ---- CREATE DATABASE db OPTIONS { seedCredentials: ..., seedConfig: ... } ---- -| The `CREATE DATABASE` options `seedCredentials` and `seedConfig` have been deprecated. S3 credentials and configuration are now read by the S3 client -from one of the normal locations, for example the executing users credentials in `$HOME/.aws/credentials`. For further infomation see .... +| The `CREATE DATABASE` options `seedCredentials` and `seedConfig` have been deprecated. For seeding from cloud storage, it is recommended to use `CloudSeedProvider` which will read cloud credentials and configuration from standard locations. For further information see link:{neo4j-docs-base-uri}/operations-manual/{page-version}/clustering/databases/#_seed_providers[Seed providers] a| label:functionality[] From fb1e6e44efb6d48dece4752590a85353607a7286 Mon Sep 17 00:00:00 2001 From: Mark Dixon <1756429+mnd999@users.noreply.github.com> Date: Thu, 31 Oct 2024 10:03:08 +0000 Subject: [PATCH 3/7] Apply suggestions from code review Co-authored-by: Therese Magnusson --- .../deprecations-additions-removals-compatibility.adoc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc b/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc index 8d109defb..275845afe 100644 --- a/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc +++ b/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc @@ -46,7 +46,9 @@ label:deprecated[] ---- CREATE DATABASE db OPTIONS { seedCredentials: ..., seedConfig: ... } ---- -| The `CREATE DATABASE` options `seedCredentials` and `seedConfig` have been deprecated. For seeding from cloud storage, it is recommended to use `CloudSeedProvider` which will read cloud credentials and configuration from standard locations. For further information see link:{neo4j-docs-base-uri}/operations-manual/{page-version}/clustering/databases/#_seed_providers[Seed providers] +| The `CREATE DATABASE` options `seedCredentials` and `seedConfig` have been deprecated. +For seeding from cloud storage, it is recommended to use `CloudSeedProvider` which will read cloud credentials and configuration from standard locations. +For further information see link:{neo4j-docs-base-uri}/operations-manual/{page-version}/clustering/databases/#_seed_providers[Seed providers]. a| label:functionality[] @@ -58,7 +60,7 @@ CREATE DATABASE db OPTIONS { storeFormat: 'standard' } CREATE DATABASE db OPTIONS { storeFormat: 'high_limit' } ---- | The standard and high_limit store formats have been deprecated. Creating databases with these formats is therefore also deprecated. -For more information on the deprecation of these formats, see link:{neo4j-docs-base-uri}/operations-manual/{page-version}/database-internals/store-formats/#format-deprecations[Format deprecations] +For more information on the deprecation of these formats, see link:{neo4j-docs-base-uri}/operations-manual/{page-version}/database-internals/store-formats/#format-deprecations[Format deprecations]. |=== [[cypher-deprecations-additions-removals-5.25]] From 2c7b3592ca29af2ba018bf4f59c319da901b0e5a Mon Sep 17 00:00:00 2001 From: Mark Dixon <1756429+mnd999@users.noreply.github.com> Date: Thu, 31 Oct 2024 11:42:25 +0000 Subject: [PATCH 4/7] Update link back to cluster docs --- .../pages/deprecations-additions-removals-compatibility.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc b/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc index 275845afe..e95459cb1 100644 --- a/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc +++ b/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc @@ -48,7 +48,7 @@ CREATE DATABASE db OPTIONS { seedCredentials: ..., seedConfig: ... } ---- | The `CREATE DATABASE` options `seedCredentials` and `seedConfig` have been deprecated. For seeding from cloud storage, it is recommended to use `CloudSeedProvider` which will read cloud credentials and configuration from standard locations. -For further information see link:{neo4j-docs-base-uri}/operations-manual/{page-version}/clustering/databases/#_seed_providers[Seed providers]. +For further information see link:{neo4j-docs-base-uri}/operations-manual/{page-version}/clustering/databases/#_cloud_seed_provider[CloudSeedProvider]. a| label:functionality[] From 6cb54148d5d13df820584756820becf255d01856 Mon Sep 17 00:00:00 2001 From: Mark Dixon <1756429+mnd999@users.noreply.github.com> Date: Fri, 1 Nov 2024 10:50:26 +0000 Subject: [PATCH 5/7] Update deprecations-additions-removals-compatibility.adoc --- .../pages/deprecations-additions-removals-compatibility.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc b/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc index e95459cb1..2a41ad5a4 100644 --- a/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc +++ b/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc @@ -48,7 +48,7 @@ CREATE DATABASE db OPTIONS { seedCredentials: ..., seedConfig: ... } ---- | The `CREATE DATABASE` options `seedCredentials` and `seedConfig` have been deprecated. For seeding from cloud storage, it is recommended to use `CloudSeedProvider` which will read cloud credentials and configuration from standard locations. -For further information see link:{neo4j-docs-base-uri}/operations-manual/{page-version}/clustering/databases/#_cloud_seed_provider[CloudSeedProvider]. +For further information see link:{neo4j-docs-base-uri}/operations-manual/{page-version}/clustering/databases/#cloud-seed-provider[CloudSeedProvider]. a| label:functionality[] From f1435a25173fe55327d6fedb3d4e471938890c35 Mon Sep 17 00:00:00 2001 From: Mark Dixon <1756429+mnd999@users.noreply.github.com> Date: Wed, 6 Nov 2024 13:36:42 +0000 Subject: [PATCH 6/7] We don't deprecate `seedConfig` anymore --- .../pages/deprecations-additions-removals-compatibility.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc b/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc index 2a41ad5a4..1bbe02257 100644 --- a/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc +++ b/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc @@ -46,7 +46,7 @@ label:deprecated[] ---- CREATE DATABASE db OPTIONS { seedCredentials: ..., seedConfig: ... } ---- -| The `CREATE DATABASE` options `seedCredentials` and `seedConfig` have been deprecated. +| The `CREATE DATABASE` option `seedCredentials` has been deprecated. For seeding from cloud storage, it is recommended to use `CloudSeedProvider` which will read cloud credentials and configuration from standard locations. For further information see link:{neo4j-docs-base-uri}/operations-manual/{page-version}/clustering/databases/#cloud-seed-provider[CloudSeedProvider]. From 329e0115cfd51c7bc2d0a07dc510a9b95fb26b21 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jens=20Pryce-=C3=85klundh?= <112686610+JPryce-Aklundh@users.noreply.github.com> Date: Mon, 11 Nov 2024 09:12:04 +0100 Subject: [PATCH 7/7] editorial --- .../deprecations-additions-removals-compatibility.adoc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc b/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc index 1bbe02257..cb6547a47 100644 --- a/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc +++ b/modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc @@ -48,7 +48,7 @@ CREATE DATABASE db OPTIONS { seedCredentials: ..., seedConfig: ... } ---- | The `CREATE DATABASE` option `seedCredentials` has been deprecated. For seeding from cloud storage, it is recommended to use `CloudSeedProvider` which will read cloud credentials and configuration from standard locations. -For further information see link:{neo4j-docs-base-uri}/operations-manual/{page-version}/clustering/databases/#cloud-seed-provider[CloudSeedProvider]. +For further information, see link:{neo4j-docs-base-uri}/operations-manual/{page-version}/clustering/databases/#cloud-seed-provider[Managing databases in a cluster -> CloudSeedProvider]. a| label:functionality[] @@ -59,8 +59,9 @@ CREATE DATABASE db OPTIONS { storeFormat: 'standard' } CREATE DATABASE db OPTIONS { storeFormat: 'high_limit' } ---- -| The standard and high_limit store formats have been deprecated. Creating databases with these formats is therefore also deprecated. -For more information on the deprecation of these formats, see link:{neo4j-docs-base-uri}/operations-manual/{page-version}/database-internals/store-formats/#format-deprecations[Format deprecations]. +| The `standard` and `high_limit` store formats have been deprecated. +Creating databases with these formats is therefore also deprecated. +For more information on the deprecation of these formats, see link:{neo4j-docs-base-uri}/operations-manual/{page-version}/database-internals/store-formats/#format-deprecations[Store formats -> Format deprecations]. |=== [[cypher-deprecations-additions-removals-5.25]]