Skip to content

Commit 16c330d

Browse files
phil198renetapopova
authored andcommitted
pr review comments
1 parent 69ce049 commit 16c330d

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

modules/ROOT/pages/authentication-authorization/ldap-integration.adoc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -434,12 +434,12 @@ CREATE USER alice
434434
SET AUTH PROVIDER 'ldap' { SET ID 'cn=alice,ou=engineering,dc=example,dc=com' }
435435
----
436436
437-
Then natively grant the `ANALYST` role to the user:
437+
Then natively grant the `READER` role to the user:
438438
----
439-
GRANT ROLE ANALYST TO alice
439+
GRANT ROLE READER TO alice
440440
----
441441
442-
This will allow the user to authenticate using `ldap` and receive the `ANALYST` role from the `native` provider.
442+
This will allow the user to authenticate using `ldap` and receive the `READER` role from the `native` provider.
443443
444444
It would also be possible to give the user the union of roles from `ldap` *and* `native` roles by setting `ldap` as an authorization provider too:
445445

modules/ROOT/pages/authentication-authorization/sso-integration.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@ dbms.security.authorization_providers=native
329329
Then create a user with a `mysso` Auth Provider:
330330
----
331331
CREATE USER jake
332-
SET AUTH 'oidc-mysso' {SET ID 'jakesUniqueMySsoId'} // this must match the claim that you configured via dbms.security.oidc.mysso.claims.username
332+
SET AUTH 'oidc-mysso' {SET ID 'jakesUniqueMySsoId'} // `jakesUniqueMySsoId` must match the value of the claim that you configured via dbms.security.oidc.mysso.claims.username
333333
----
334334
335335
Then natively grant the `READER` role to the user:

modules/ROOT/pages/tutorial/tutorial-sso-configuration.adoc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ For example to create a user `jake` who can authenticate using native or Okta, a
142142
----
143143
CREATE USER jake
144144
SET HOME DATABASE 'jakesHomeDb'
145-
SET AUTH 'oidc-okta' {SET ID 'jakesUniqueOktaUserId'} // this must match the claim that you configured via dbms.security.oidc.okta.claims.username
145+
SET AUTH 'oidc-okta' {SET ID 'jakesUniqueOktaUserId'} // `jakesUniqueOktaUserId` must match the value of the claim that you configured via dbms.security.oidc.okta.claims.username
146146
SET AUTH 'native' {SET PASSWORD 'changeme' SET PASSWORD CHANGE REQUIRED}
147147
----
148148

@@ -334,7 +334,7 @@ For example to create a user `jake` who can authenticate and authorize using Ent
334334
----
335335
CREATE USER jake
336336
SET HOME DATABASE 'jakesHomeDb'
337-
SET AUTH 'oidc-okta' {SET ID 'jakesUniqueEntraUserId'} // this must match the claim that you configured via dbms.security.oidc.azure.claims.username
337+
SET AUTH 'oidc-okta' {SET ID 'jakesUniqueEntraUserId'} // `jakesUniqueEntraUserId` must match the value of the claim that you configured via dbms.security.oidc.azure.claims.username
338338
----
339339

340340
See xref:authentication-authorization/sso-integration.adoc#auth-sso-auth-providers[SSO integration] for further examples.
@@ -401,7 +401,7 @@ dbms.security.require_local_user=true
401401
----
402402
CREATE USER jake
403403
SET HOME DATABASE 'jakesHomeDb'
404-
SET AUTH 'oidc-google' {SET ID 'jakesUniqueGoogleUserId'} // this must match the claim that you configured via dbms.security.oidc.google.claims.username
404+
SET AUTH 'oidc-google' {SET ID 'jakesUniqueGoogleUserId'} // `jakesUniqueGoogleUserId` must match the value of the claim that you configured via dbms.security.oidc.google.claims.username
405405
----
406406

407407
.. Grant the user roles using native authorization.
@@ -453,7 +453,7 @@ dbms.security.authentication_providers=oidc-google
453453

454454
[source, cypher, role=noplay]
455455
----
456-
CREATE USER jakesUniqueGoogleUserId // this must match the claim that you configured via dbms.security.oidc.google.claims.username
456+
CREATE USER jakesUniqueGoogleUserId // `jakesUniqueGoogleUserId` must match the value of the claim that you configured via dbms.security.oidc.google.claims.username
457457
SET HOME DATABASE 'jakesHomeDb'
458458
SET PASSWORD 'secretpassword' SET PASSWORD CHANGE NOT
459459
REQUIRED

0 commit comments

Comments
 (0)