Skip to content

Commit 31f181a

Browse files
Apply suggestions from code review
Co-authored-by: Reneta Popova <[email protected]>
1 parent eec2d0b commit 31f181a

File tree

1 file changed

+15
-12
lines changed

1 file changed

+15
-12
lines changed

modules/ROOT/pages/clustering/setup/discovery.adoc

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -304,13 +304,14 @@ The discovery addresses should include addresses of the new members, and the pre
304304
+
305305
As an example, for those using the list resolver, the settings for the new servers should include:
306306
+
307-
```
307+
[source, parameters]
308+
----
308309
dbms.cluster.discovery.resolver_type=LIST
309310
dbms.cluster.discovery.version=V1_OVER_V2
310311
311312
dbms.cluster.discovery.endpoints=server01.example.com:5000,server02.example.com:5000,server03.example.com:5000,server04.example.com:5000,server05.example.com:5000,server06.example.com:5000
312313
dbms.cluster.discovery.v2.endpoints=server01.example.com:6000,server02.example.com:6000,server03.example.com:6000,server04.example.com:6000,server05.example.com:6000,server06.example.com:6000
313-
```
314+
----
314315
+
315316
. Using `bolt://`, connect to the system database of servers 4, 5, 6, and run the following procedure.
316317
This can be done using via `./cypher-shell -a bolt://localhost:7685 -d system` for example.
@@ -343,13 +344,14 @@ The discovery addresses in the settings should include addresses of the new memb
343344
+
344345
As an example, for those using the list resolver, the settings for the new servers should include:
345346
+
346-
```
347+
[source, parameters]
348+
----
347349
dbms.cluster.discovery.resolver_type=LIST
348350
dbms.cluster.discovery.version=V2_OVER_V1
349351
350352
dbms.cluster.discovery.endpoints=server04.example.com:5000,server05.example.com:5000,server06.example.com:5000,server07.example.com:5000,server08.example.com:5000,server09.example.com:5000
351353
dbms.cluster.discovery.v2.endpoints=server04.example.com:6000,server05.example.com:6000,server06.example.com:6000,server07.example.com:6000,server08.example.com:6000,server09.example.com:6000
352-
```
354+
----
353355
+
354356
. Using `bolt://`, connect to the system database of servers 7, 8, 9 and run the following procedure:
355357
+
@@ -358,7 +360,7 @@ dbms.cluster.discovery.v2.endpoints=server04.example.com:6000,server05.example.c
358360
CALL dbms.cluster.showParallelDiscoveryState();
359361
----
360362
+
361-
The output should display `Matching` in the `stateComparison`.
363+
The output should display `Matching` in the `stateComparison` column.
362364
If they are not, wait and try again till matching.
363365
+
364366
.Expected result
@@ -382,12 +384,13 @@ Note that only the v2 settings are required.
382384
+
383385
As an example, for those using the list resolver, the settings for the new servers should include:
384386
+
385-
```
387+
[source, parameters]
388+
----
386389
dbms.cluster.discovery.resolver_type=LIST
387390
dbms.cluster.discovery.version=V2_ONLY
388391
389392
dbms.cluster.discovery.v2.endpoints=server07.example.com:6000,server08.example.com:6000,server09.example.com:6000,server10.example.com:6000,server11.example.com:6000,server12.example.com:6000
390-
```
393+
----
391394
+
392395
. Deallocate, drop, and shut down servers 7, 8, 9.
393396
+
@@ -408,7 +411,6 @@ CALL dbms.cluster.showParallelDiscoveryState();
408411
+-------------------------------------------------------------+
409412
----
410413
[[discovery-v1-to-v2-procedures]]
411-
412414
=== Using procedures
413415

414416
// By using just procedures, the nice thing is that during the user's normal version upgrade, they can also add the new settings required for v2 discovery service.
@@ -420,14 +422,15 @@ CALL dbms.cluster.showParallelDiscoveryState();
420422
+
421423
As an example, for those using the list resolver, the settings for all the servers should include:
422424
+
423-
```
425+
[source, parameters]
426+
----
424427
dbms.cluster.discovery.resolver_type=LIST
425428
426429
dbms.cluster.discovery.endpoints=server01.example.com:5000,server02.example.com:5000,server03.example.com:5000
427430
dbms.cluster.discovery.v2.endpoints=server01.example.com:6000,server02.example.com:6000,server03.example.com:6000
428-
```
431+
----
429432
+
430-
. In Cypher Shell, connect to the system database of server01 using `bolt://`.
433+
. In Cypher Shell, connect to the `system` database of server01 using `bolt://`.
431434
It is important to connect via `bolt://` because otherwise the procedure might be routed and executed not on the intended server.
432435
+
433436
[source, shell, role=nocopy noplay]
@@ -491,7 +494,7 @@ This is no reason for worry.
491494

492495
. Check the state on all servers again.
493496
It should show that the states are `Matching`.
494-
Both serverCounts should be 3.
497+
Both `serverCounts` should be 3.
495498
+
496499
.Expected result
497500
[queryresult]

0 commit comments

Comments
 (0)