Skip to content

Conversation

@JPryce-Aklundh
Copy link
Contributor

@JPryce-Aklundh JPryce-Aklundh commented Sep 19, 2024

Once merged, we need to create a redirect for reference/procedures.adoc and the reference/index.adoc.

@JPryce-Aklundh JPryce-Aklundh changed the title Procedure playground Restructure Procedures page and add new Details tables Sep 19, 2024
@renetapopova renetapopova self-assigned this Oct 10, 2024
@renetapopova renetapopova marked this pull request as ready for review October 15, 2024 08:01
Copy link

@mnssn mnssn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have looked over the grouping and it looks reasonable to me.

I have only skimmed the signatures. Let me know if this is sufficient, or if you want me to do a more thorough pass.

@renetapopova
Copy link
Collaborator

I have looked over the grouping and it looks reasonable to me.

I have only skimmed the signatures. Let me know if this is sufficient, or if you want me to do a more thorough pass.

Thank you, @mnssn! Everything else should be fine as we test them.

| *Mode* 3+| DBMS
|===


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, now we don't have a table with all active procedures, do we? We have only 2 tables with removed and deprecated procedures respectively?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's correct. We have all procedures + deprecated and removed in case users are interested in what's deprecated in particular.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be wrong but our test reports two views: summary (for a table) and detailed (for a list of procedures with descr)
So, now it fails because the table was removed

@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Nov 22, 2024

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@renetapopova renetapopova merged commit 5a69402 into neo4j:dev Nov 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants