From 4e4ec33f2fbf5bdc0ed2fdb50435fafbccf07f50 Mon Sep 17 00:00:00 2001 From: Reneta Popova Date: Tue, 6 May 2025 18:05:38 +0100 Subject: [PATCH 1/3] Add a note that obfuscate literals does not work with malformed queries --- modules/ROOT/pages/configuration/configuration-settings.adoc | 4 ++++ modules/ROOT/pages/monitoring/logging.adoc | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/modules/ROOT/pages/configuration/configuration-settings.adoc b/modules/ROOT/pages/configuration/configuration-settings.adoc index a5382d127..94b41d722 100644 --- a/modules/ROOT/pages/configuration/configuration-settings.adoc +++ b/modules/ROOT/pages/configuration/configuration-settings.adoc @@ -2457,6 +2457,10 @@ a|A boolean. m|+++false+++ |=== +[NOTE] +==== +Keep in mind that if Neo4j receives a malformed query that cannot be parsed, it cannot obfuscate its literals (because it does not know which parts are literals) and, therefore, the query text will not be included in any logging. +==== [role=label--dynamic] [[config_db.logs.query.parameter_logging_enabled]] diff --git a/modules/ROOT/pages/monitoring/logging.adoc b/modules/ROOT/pages/monitoring/logging.adoc index c467fb04f..5235bbd99 100644 --- a/modules/ROOT/pages/monitoring/logging.adoc +++ b/modules/ROOT/pages/monitoring/logging.adoc @@ -875,8 +875,10 @@ This is useful when Cypher queries expose sensitive information. ==== Node labels, relationship types, and map property keys are still shown. Changing the setting does not affect cached queries. -Therefore, if you want the switch to have an immediate effect, you must also clear the query cache; `CALL db.clearQueryCaches()`. +Therefore, if you want the switch to have an immediate effect, you must also clear the query cache; `CALL db.clearQueryCaches()`. + +Also, keep in mind that if Neo4j receives a malformed query that cannot be parsed, it cannot obfuscate its literals (because it does not know which parts are literals) and, therefore, the query text will not be included in any logging. ==== + [WARNING] ==== This does not obfuscate literals in parameters. From b6b62a047a36c1d4f31a3d6744aa120d9a52eea8 Mon Sep 17 00:00:00 2001 From: Reneta Popova Date: Wed, 7 May 2025 09:53:39 +0100 Subject: [PATCH 2/3] fix the failing test --- modules/ROOT/pages/configuration/configuration-settings.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/ROOT/pages/configuration/configuration-settings.adoc b/modules/ROOT/pages/configuration/configuration-settings.adoc index 94b41d722..6d41f6f95 100644 --- a/modules/ROOT/pages/configuration/configuration-settings.adoc +++ b/modules/ROOT/pages/configuration/configuration-settings.adoc @@ -1699,7 +1699,7 @@ m|+++true+++ |Description a|The load balancing plugin to use. |Valid values -a|A string that specified load balancer plugin exist.. +a|A string. |Default value m|+++server_policies+++ |=== From 36c5e85836f2227dfbe9806f9acbe89bdc17e40a Mon Sep 17 00:00:00 2001 From: Reneta Popova Date: Wed, 7 May 2025 10:54:05 +0100 Subject: [PATCH 3/3] Update modules/ROOT/pages/configuration/configuration-settings.adoc Revert this change as it's not related to this PR and is being fixed in another one. --- modules/ROOT/pages/configuration/configuration-settings.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/ROOT/pages/configuration/configuration-settings.adoc b/modules/ROOT/pages/configuration/configuration-settings.adoc index 6d41f6f95..94b41d722 100644 --- a/modules/ROOT/pages/configuration/configuration-settings.adoc +++ b/modules/ROOT/pages/configuration/configuration-settings.adoc @@ -1699,7 +1699,7 @@ m|+++true+++ |Description a|The load balancing plugin to use. |Valid values -a|A string. +a|A string that specified load balancer plugin exist.. |Default value m|+++server_policies+++ |===