Skip to content

Conversation

@l-heemann
Copy link
Contributor

@l-heemann l-heemann commented Jun 24, 2025

@l-heemann l-heemann force-pushed the graph-reference-C25 branch from adc6ac6 to 975bf2c Compare June 25, 2025 08:14
@l-heemann l-heemann changed the title Graph reference updates for Cypher 25 / Neo4j 2025.06 (targeting dev) Graph reference updates for Cypher 25 / Neo4j 2025.06 Jun 25, 2025
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think this is a good way to explain a complex topic. I am happy with the structure we landed in. Only a bunch of smaller comments on various details.

Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, looks good now

Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Lasse. I added some comments.

@l-heemann
Copy link
Contributor Author

Thanks for the review @renetapopova

I've added links for the GQL codes but it seems I did it wrong since the build fails now? 🤷

@renetapopova
Copy link
Collaborator

Thanks for the review @renetapopova

I've added links for the GQL codes but it seems I did it wrong since the build fails now? 🤷

There is somewhere unterminated example block

Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me fix those unterminated blocks.

. Constituent alias `flowers` within composite database `my.garden.beautiful`.
. Regular non-composite alias `my.garden.beautiful.flowers`.

.Query
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this query needs to go away as it duplicates the one above now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I fixed this now with 8c36c96

@renetapopova renetapopova self-requested a review June 26, 2025 13:11
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks great! Just one typo.

@l-heemann
Copy link
Contributor Author

I think it looks great! Just one typo.

Great! I don't want to interfere with the other PRs going on in this repo, so I think I'll wait with rebase/merging this until those are merged :)

Comment on lines +265 to +272
CYPHER 25 CREATE ALIAS `garden.flowers` FOR DATABASE `northwind-graph`
CYPHER 25 CREATE ALIAS `garden.flowers` FOR DATABASE `northwind-graph`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't one of these be un escaped to show some difference in the commands?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was intentional. As Cypher 25 is going out today, we will merge this PR but feel free to double-check this with Lasse when he is back from vacation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, @l-heemann can confirm if that is something we want to update when he gets back :P

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is intentional to show the difference between Cypher 5 and 25 (by toggling the tabbed view back and forth)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But having both the CYPHER 25 commands be identical feels weird to me... if I did that in Cypher 5 I would fail on it trying to create the same thing twice as well... so why not have one garden.flowers (unescaped) and one `garden.flowers` (escaped together) in the Cypher 25 example 🤔 wouldn't that be closer to the commands for Cypher 5 (that does differ in that one is escaped together and one separately)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be making it less clear by introducing a third variation (unquoted). The whole point of this section is to show that the syntax used to differentiate between composite constituent and regular alias, but now there is no syntactic difference and therefore the error says "these things are the same".

I didn't come up with a better way to highlight "no syntactic difference" other than showing the two identical lines next to each other.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 just looked odd to me

Comment on lines 23 to 24
Database names are the only identifier for which dots do not need to be quoted.
For example `main.db` is a valid database name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't these two make sense to keep? 🤔

Copy link
Contributor

@Lojjs Lojjs Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a conflict on this line, so it seems this text is not looking like this in dev anymore. When I did a rebase this text was already removed as part of some already merged PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with it, but I still think having Database names are the only identifier for which dots do not need to be quoted. might be nice, since that is something that separates the database names with other identifiers 🤷

l-heemann and others added 7 commits July 2, 2025 11:28
@Lojjs Lojjs force-pushed the graph-reference-C25 branch from 90f8297 to 8046749 Compare July 2, 2025 09:43
@neo4j-docops-agent
Copy link
Collaborator

neo4j-docops-agent commented Jul 2, 2025

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@NataliaIvakina NataliaIvakina merged commit 47973b3 into neo4j:dev Jul 2, 2025
8 checks passed
NataliaIvakina pushed a commit to NataliaIvakina/docs-operations that referenced this pull request Jul 2, 2025
Documentation for:
CIP-212
neo-technology/neo4j#31208
neo-technology/neo4j#31418

---------

Co-authored-by: Louise Berglund <[email protected]>
Co-authored-by: Reneta Popova <[email protected]>
Lojjs added a commit that referenced this pull request Jul 7, 2025
Backporting relevant parts of
#2443 to 5.26 as the
previous deprecation has been removed from 5.26.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants