-
Notifications
You must be signed in to change notification settings - Fork 83
Graph reference updates for Cypher 25 / Neo4j 2025.06 #2443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
adc6ac6 to
975bf2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I think this is a good way to explain a complex topic. I am happy with the structure we landed in. Only a bunch of smaller comments on various details.
modules/ROOT/pages/database-administration/aliases/naming-aliases.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/database-administration/aliases/manage-aliases-composite-databases.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/database-administration/aliases/manage-aliases-composite-databases.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/database-administration/aliases/manage-aliases-composite-databases.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/database-administration/aliases/manage-aliases-composite-databases.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/database-administration/aliases/manage-aliases-composite-databases.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/database-administration/aliases/manage-aliases-composite-databases.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/database-administration/aliases/manage-aliases-composite-databases.adoc
Show resolved
Hide resolved
modules/ROOT/pages/database-administration/aliases/manage-aliases-composite-databases.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes, looks good now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Lasse. I added some comments.
modules/ROOT/pages/database-administration/aliases/manage-aliases-composite-databases.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/database-administration/aliases/manage-aliases-composite-databases.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/database-administration/aliases/manage-aliases-composite-databases.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/database-administration/aliases/manage-aliases-composite-databases.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/database-administration/aliases/manage-aliases-composite-databases.adoc
Show resolved
Hide resolved
modules/ROOT/pages/database-administration/aliases/manage-aliases-composite-databases.adoc
Show resolved
Hide resolved
modules/ROOT/pages/database-administration/aliases/manage-aliases-composite-databases.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/database-administration/aliases/naming-aliases.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/database-administration/aliases/naming-aliases.adoc
Outdated
Show resolved
Hide resolved
...les/ROOT/pages/database-administration/composite-databases/querying-composite-databases.adoc
Show resolved
Hide resolved
|
Thanks for the review @renetapopova I've added links for the GQL codes but it seems I did it wrong since the build fails now? 🤷 |
There is somewhere unterminated example block |
modules/ROOT/pages/database-administration/aliases/manage-aliases-composite-databases.adoc
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me fix those unterminated blocks.
modules/ROOT/pages/database-administration/aliases/manage-aliases-composite-databases.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/database-administration/aliases/manage-aliases-composite-databases.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/database-administration/aliases/manage-aliases-composite-databases.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/database-administration/aliases/manage-aliases-composite-databases.adoc
Outdated
Show resolved
Hide resolved
| . Constituent alias `flowers` within composite database `my.garden.beautiful`. | ||
| . Regular non-composite alias `my.garden.beautiful.flowers`. | ||
|
|
||
| .Query |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this query needs to go away as it duplicates the one above now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I fixed this now with 8c36c96
modules/ROOT/pages/database-administration/aliases/manage-aliases-composite-databases.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks great! Just one typo.
Great! I don't want to interfere with the other PRs going on in this repo, so I think I'll wait with rebase/merging this until those are merged :) |
| CYPHER 25 CREATE ALIAS `garden.flowers` FOR DATABASE `northwind-graph` | ||
| CYPHER 25 CREATE ALIAS `garden.flowers` FOR DATABASE `northwind-graph` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't one of these be un escaped to show some difference in the commands?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was intentional. As Cypher 25 is going out today, we will merge this PR but feel free to double-check this with Lasse when he is back from vacation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, @l-heemann can confirm if that is something we want to update when he gets back :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is intentional to show the difference between Cypher 5 and 25 (by toggling the tabbed view back and forth)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But having both the CYPHER 25 commands be identical feels weird to me... if I did that in Cypher 5 I would fail on it trying to create the same thing twice as well... so why not have one garden.flowers (unescaped) and one `garden.flowers` (escaped together) in the Cypher 25 example 🤔 wouldn't that be closer to the commands for Cypher 5 (that does differ in that one is escaped together and one separately)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be making it less clear by introducing a third variation (unquoted). The whole point of this section is to show that the syntax used to differentiate between composite constituent and regular alias, but now there is no syntactic difference and therefore the error says "these things are the same".
I didn't come up with a better way to highlight "no syntactic difference" other than showing the two identical lines next to each other.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷 just looked odd to me
| Database names are the only identifier for which dots do not need to be quoted. | ||
| For example `main.db` is a valid database name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't these two make sense to keep? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a conflict on this line, so it seems this text is not looking like this in dev anymore. When I did a rebase this text was already removed as part of some already merged PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with it, but I still think having Database names are the only identifier for which dots do not need to be quoted. might be nice, since that is something that separates the database names with other identifiers 🤷
…ses-composite-databases.adoc Co-authored-by: Lasse Heemann <[email protected]>
Co-authored-by: Reneta Popova <[email protected]>
Move label from individual examples to whole section Co-authored-by: Reneta Popova <[email protected]>
…ses-composite-databases.adoc
GQL section review fixes Co-authored-by: Reneta Popova <[email protected]>
…ses-composite-databases.adoc Co-authored-by: Reneta Popova <[email protected]>
90f8297 to
8046749
Compare
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
Documentation for: CIP-212 neo-technology/neo4j#31208 neo-technology/neo4j#31418 --------- Co-authored-by: Louise Berglund <[email protected]> Co-authored-by: Reneta Popova <[email protected]>
Backporting relevant parts of #2443 to 5.26 as the previous deprecation has been removed from 5.26.9
Documentation for:
CIP-212
https://github.com/neo-technology/neo4j/pull/31208
https://github.com/neo-technology/neo4j/pull/31418