Commit c34844c
https://trello.com/c/1ymz1Qiq/975-create-a-notification-when-doing-allocations-while-some-servers-are-cordoned
This PR proposes the introduction of the
`CordonedServersExistedDuringAllocation` notification. This will be
returned whenever a command that triggers a database allocation decision
is executed. This includes `CREATE DATABASE`, `ALTER DATABASE`,
`DEALLOCATE DATABASES FROM SERVER`, `ALTER SERVER`. But not `REALLOCATE
DATABASES` as this command has the requirement for no cordoned servers
and errors if there is such a server.
This is useful to remind the person managing the cluster that some
servers are cordoned and this impacts the allocation decision (databases
can't be allocated to cordoned servers). So this should help the user
not get confused by the allocation decisions made.
I have included this as a `WARNING` initially but maybe `INFORMATION`
would be better suited, not sure on the criteria to be made a `WARNING`.
Cordoned servers aren't necessarily a bad thing in themselves but their
existence could lead to "worse" allocation decision than if they were
uncordoned. So, the warning could be seen as a prompt the user to do
something about the cordoned server.
Co-authored-by: Jack Waudby <[email protected]>
1 parent cb969c3 commit c34844c
File tree
2 files changed
+47
-0
lines changed- modules/ROOT/pages
- notifications
2 files changed
+47
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
4 | 13 | | |
5 | 14 | | |
6 | 15 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1233 | 1233 | | |
1234 | 1234 | | |
1235 | 1235 | | |
| 1236 | + | |
| 1237 | + | |
| 1238 | + | |
| 1239 | + | |
| 1240 | + | |
| 1241 | + | |
| 1242 | + | |
| 1243 | + | |
| 1244 | + | |
| 1245 | + | |
| 1246 | + | |
| 1247 | + | |
| 1248 | + | |
| 1249 | + | |
| 1250 | + | |
| 1251 | + | |
| 1252 | + | |
| 1253 | + | |
| 1254 | + | |
| 1255 | + | |
| 1256 | + | |
| 1257 | + | |
| 1258 | + | |
| 1259 | + | |
| 1260 | + | |
| 1261 | + | |
| 1262 | + | |
| 1263 | + | |
| 1264 | + | |
| 1265 | + | |
| 1266 | + | |
| 1267 | + | |
| 1268 | + | |
| 1269 | + | |
| 1270 | + | |
| 1271 | + | |
| 1272 | + | |
| 1273 | + | |
1236 | 1274 | | |
1237 | 1275 | | |
1238 | 1276 | | |
| |||
0 commit comments