Skip to content

Commit 3f6d434

Browse files
authored
Fix terminology: deployment branch policies, not branch protection rules (#129)
Caught by Copilot review on the docs-playbook PR documenting this behavior. "Branch protection rules" names a different, unrelated repo-level GitHub feature (PR requirements, required status checks) - what actually restricts which branches/tags can use an environment is called deployment branch policies.
1 parent 665f388 commit 3f6d434

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/reusable-docs-build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,10 +131,10 @@ jobs:
131131
outputs:
132132
pages-listed: ${{ steps.page-list-artifact.outcome }}
133133

134-
# Only scope to an environment (and its branch protection rules) for actual
134+
# Only scope to an environment (and its deployment branch policies) for actual
135135
# publish builds, which are the only ones that need DOCS_PUBLISH_URL. Ordinary
136136
# preview builds (e.g. PR checks) don't need it and shouldn't be blocked by
137-
# environment branch-protection rules meant for publishing.
137+
# environment deployment branch policies meant for publishing.
138138
environment:
139139
name: ${{ inputs.package-script == 'verify:publish' && inputs.publish-env || '' }}
140140
deployment: false

0 commit comments

Comments
 (0)