Create translation (#6488)

* WIP Use new translation layer on create mutations

* Add nested create

* wip add connect to create

* WIP nested connect operation in create

* WIP fix create projection

* WIP fix projection in create

* WIP populatedBy

* wip special callback bucket

* Rename deprecate old callback bucket

* WIP populatedBy callbackBucket

* fix list coerce in callbacks

* fix expectation of time value in callbacks

* populatedBy fields in edge

* extend translation of ConnectOperation

* fix cypher fields in filters

* fix empty filters case on connect

* support multiple inputs for create

* add auth to create mutations

* WIP fix auth in create

* auth in create translation

* WIP multiple inputs

* enable unwind create

* remove uncommented code

* fix auth in create operation

* supports no projection in create

* check for graphql errors in tests, separate concrete implementation from composite implementation in create mutation

* WIP translation of nested connect with interfaces

* Add create-connect-connect to new translation layer

* create->connect interfaces

* create-> create with interfaces

* Improve CreateFactory

* Create and connect operations on unions

* WIP cleanup createFactory

* Update tck tests

* cleanup of top level create mutation operation

* Fix linting errors

* Remove some comments

* remove duplicate authorization, console.log from tests, and unreachable code

* update tck tests

* Add authorization to connect operation

* Add tests on create-authorization

* Handle after auth in conneciton operations

* Code review improvements

* Remove unused method from expect relationship

* Add more type checks on neo-expect

---------

Co-authored-by: a-alle <[email protected]>
Co-authored-by: MacondoExpress <[email protected]>

Author: 3 people

.changeset/metal-trams-smile.md

@@ -0,0 +1,5 @@
+---
+"@neo4j/graphql": patch
+---
+
+Fix format of Time and spatial input types

packages/graphql/src/classes/CallbackBucket.ts renamed to packages/graphql/src/classes/CallbackBucketDeprecated.ts

@@ -57,7 +57,8 @@ type CallbackResult =
     | Duration<Integer>
     | Array<CallbackResult>;
 
-export class CallbackBucket {
+/** @deprecated */
+export class CallbackBucketDeprecated {
     public callbacks: Callback[];
     private context: Neo4jGraphQLTranslationContext;
 

packages/graphql/src/schema-model/entity/model-adapters/ConcreteEntityAdapter.ts

@@ -191,6 +191,21 @@ export class ConcreteEntityAdapter {
         return Array.from(this.attributes.values()).filter((attribute) => attribute.isEventPayloadField());
     }
 
+    public getPopulatedByFields(operation: "CREATE" | "UPDATE"): AttributeAdapter[] {
+        switch (operation) {
+            case "CREATE":
+                return Array.from(this.attributes.values()).filter((attribute) =>
+                    attribute.populatedByCreateIsGenerated()
+                );
+            case "UPDATE":
+                return Array.from(this.attributes.values()).filter((attribute) =>
+                    attribute.populatedByUpdateIsGenerated()
+                );
+            default:
+                throw new Error("Invalid operation");
+        }
+    }
+
     public isSubscribable(schemaModel: Neo4jGraphQLSchemaModel): boolean {
         if (this.annotations.subscription) {
             return this.annotations.subscription.events?.size > 0;

packages/graphql/src/schema-model/relationship/model-adapters/RelationshipAdapter.ts

@@ -260,6 +260,21 @@ export class RelationshipAdapter {
         return Array.from(this.attributes.values()).filter((attribute) => attribute.typeHelper.isTemporal());
     }
 
+    public getPopulatedByFields(operation: "CREATE" | "UPDATE"): AttributeAdapter[] {
+        switch (operation) {
+            case "CREATE":
+                return Array.from(this.attributes.values()).filter((attribute) =>
+                    attribute.populatedByCreateIsGenerated()
+                );
+            case "UPDATE":
+                return Array.from(this.attributes.values()).filter((attribute) =>
+                    attribute.populatedByUpdateIsGenerated()
+                );
+            default:
+                throw new Error("Invalid operation");
+        }
+    }
+
     public get subscriptionConnectedRelationshipFields(): AttributeAdapter[] {
         return Array.from(this.attributes.values()).filter((attribute) =>
             attribute.isSubscriptionConnectedRelationshipField()

packages/graphql/src/translate/create-connect-and-params.test.ts

@@ -22,7 +22,7 @@ import type { Node } from "../../src/classes";
 import { ContextBuilder } from "../../tests/utils/builders/context-builder";
 import { NodeBuilder } from "../../tests/utils/builders/node-builder";
 import { SchemaModelBuilder } from "../../tests/utils/builders/schema-model-builder";
-import { CallbackBucket } from "../classes/CallbackBucket";
+import { CallbackBucketDeprecated } from "../classes/CallbackBucketDeprecated";
 import { Neo4jDatabaseInfo } from "../classes/Neo4jDatabaseInfo";
 import { RelationshipQueryDirectionOption } from "../constants";
 import { defaultNestedOperations } from "../graphql/directives/relationship";
@@ -121,7 +121,7 @@ describe("createConnectAndParams", () => {
             context,
             refNodes: [node],
             parentNode: node,
-            callbackBucket: new CallbackBucket(context),
+            callbackBucket: new CallbackBucketDeprecated(context),
             source: "CONNECT",
         });
 

packages/graphql/src/translate/create-connect-and-params.ts

@@ -19,7 +19,7 @@
 
 import Cypher from "@neo4j/cypher-builder";
 import type { Node, Relationship } from "../classes";
-import type { CallbackBucket } from "../classes/CallbackBucket";
+import type { CallbackBucketDeprecated } from "../classes/CallbackBucketDeprecated";
 import type { EntityAdapter } from "../schema-model/entity/EntityAdapter";
 import { InterfaceEntity } from "../schema-model/entity/InterfaceEntity";
 import type { ConcreteEntityAdapter } from "../schema-model/entity/model-adapters/ConcreteEntityAdapter";
@@ -70,7 +70,7 @@ function createConnectAndParams({
     relationField: RelationField;
     parentVar: string;
     context: Neo4jGraphQLTranslationContext;
-    callbackBucket: CallbackBucket;
+    callbackBucket: CallbackBucketDeprecated;
     refNodes: Node[];
     labelOverride?: string;
     parentNode: Node;

packages/graphql/src/translate/create-create-and-params.test.ts

@@ -19,7 +19,7 @@
 
 import { ContextBuilder } from "../../tests/utils/builders/context-builder";
 import { NodeBuilder } from "../../tests/utils/builders/node-builder";
-import { CallbackBucket } from "../classes/CallbackBucket";
+import { CallbackBucketDeprecated } from "../classes/CallbackBucketDeprecated";
 import { Neo4jGraphQLSchemaModel } from "../schema-model/Neo4jGraphQLSchemaModel";
 import { Attribute } from "../schema-model/attribute/Attribute";
 import { GraphQLBuiltInScalarType, ScalarType } from "../schema-model/attribute/AttributeType";
@@ -109,7 +109,7 @@ describe("createCreateAndParams", () => {
         const result = createCreateAndParams({
             input,
             node,
-            callbackBucket: new CallbackBucket(context),
+            callbackBucket: new CallbackBucketDeprecated(context),
             context,
             varName: "this0",
             withVars: ["this0"],

packages/graphql/src/translate/create-create-and-params.ts

@@ -18,7 +18,7 @@
  */
 
 import type { Node, Relationship } from "../classes";
-import type { CallbackBucket } from "../classes/CallbackBucket";
+import type { CallbackBucketDeprecated } from "../classes/CallbackBucketDeprecated";
 import type { Neo4jGraphQLTranslationContext } from "../types/neo4j-graphql-translation-context";
 import { getRelationshipType } from "../utils/get-relationship-type";
 import mapToDbProperty from "../utils/map-to-db-property";
@@ -64,7 +64,7 @@ function createCreateAndParams({
     varName: string;
     node: Node;
     context: Neo4jGraphQLTranslationContext;
-    callbackBucket: CallbackBucket;
+    callbackBucket: CallbackBucketDeprecated;
     withVars: string[];
     topLevelNodeVariable?: string;
     //used to build authorization variable in auth subqueries

packages/graphql/src/translate/create-set-relationship-properties.ts

@@ -18,7 +18,7 @@
  */
 
 import { type Relationship } from "../classes";
-import type { CallbackBucket } from "../classes/CallbackBucket";
+import type { CallbackBucketDeprecated } from "../classes/CallbackBucketDeprecated";
 import type { RelationshipAdapter } from "../schema-model/relationship/model-adapters/RelationshipAdapter";
 import { assertNonAmbiguousUpdate } from "./utils/assert-non-ambiguous-update";
 import { addCallbackAndSetParam } from "./utils/callback-utils";
@@ -42,7 +42,7 @@ export function createSetRelationshipProperties({
     relationship: Relationship;
     relationshipAdapter?: RelationshipAdapter;
     operation: "CREATE" | "UPDATE";
-    callbackBucket: CallbackBucket;
+    callbackBucket: CallbackBucketDeprecated;
     parameterPrefix: string;
     parameterNotation: "." | "_";
     isUpdateOperation?: boolean;
@@ -95,7 +95,7 @@ function createSetRelationshipPropertiesForProperties({
     withVars: string[];
     relationship: Relationship;
     operation: "CREATE" | "UPDATE";
-    callbackBucket: CallbackBucket;
+    callbackBucket: CallbackBucketDeprecated;
     parameterPrefix: string;
     parameterNotation: "." | "_";
     isUpdateOperation: boolean;

packages/graphql/src/translate/create-update-and-params.test.ts

@@ -19,7 +19,7 @@
 
 import { ContextBuilder } from "../../tests/utils/builders/context-builder";
 import { NodeBuilder } from "../../tests/utils/builders/node-builder";
-import { CallbackBucket } from "../classes/CallbackBucket";
+import { CallbackBucketDeprecated } from "../classes/CallbackBucketDeprecated";
 import { Neo4jGraphQLSchemaModel } from "../schema-model/Neo4jGraphQLSchemaModel";
 import { Attribute } from "../schema-model/attribute/Attribute";
 import { GraphQLBuiltInScalarType, ScalarType } from "../schema-model/attribute/AttributeType";
@@ -103,7 +103,7 @@ describe("createUpdateAndParams", () => {
             parentVar: "this",
             withVars: ["this"],
             parameterPrefix: "this",
-            callbackBucket: new CallbackBucket(context),
+            callbackBucket: new CallbackBucketDeprecated(context),
         });
 
         expect(trimmer(result[0])).toEqual(