Merge pull request #6589 from neo4j/6585-populatedBy-bug-in-nested-create

Fix #6585

Author: angrykoala

.changeset/yellow-kiwis-go.md

@@ -0,0 +1,5 @@
+---
+"@neo4j/graphql": patch
+---
+
+Fix regression on `@populatedBy` where nested create operations don't trigger callbacks

packages/graphql/src/translate/queryAST/ast/input-fields/TimestampField.ts

@@ -30,14 +30,11 @@ export class TimestampField extends InputField {
         super(name, attachedTo);
         this.attribute = attribute;
     }
+
     public getChildren() {
         return [];
     }
 
-    public print(): string {
-        return `${super.print()} <${this.name}>`;
-    }
-
     public getSetParams(queryASTContext: QueryASTContext<Cypher.Node>): Cypher.SetParam[] {
         const target = this.getTarget(queryASTContext);
         const relatedCypherExpression = this.GetFunctionForTemporalType(

packages/graphql/src/translate/queryAST/factory/Operations/CreateFactory.ts

@@ -388,7 +388,6 @@ export class CreateFactory {
             create,
             input,
             callbackBucket,
-            isNested,
             relationship,
         });
     }
@@ -460,42 +459,40 @@ export class CreateFactory {
         create,
         input,
         callbackBucket,
-        isNested,
         relationship,
     }: {
         entity: ConcreteEntityAdapter;
         create: CreateOperation;
         input: Record<string, any>;
         callbackBucket: CallbackBucket;
-        isNested: boolean;
         relationship?: RelationshipAdapter;
     }) {
-        if (!isNested) {
-            entity.getPopulatedByFields("CREATE").forEach((attribute) => {
-                const attachedTo = "node";
-                // the param value it's irrelevant as it will be overwritten by the callback function
-                const callbackParam = new Cypher.Param("1234");
-                const field = new ParamInputField({
-                    attribute,
-                    attachedTo,
-                    inputValue: callbackParam,
-                });
-                create.addField(field);
+        entity.getPopulatedByFields("CREATE").forEach((attribute) => {
+            const attachedTo = "node";
+            // the param value it's irrelevant as it will be overwritten by the callback function
+            const callbackParam = new Cypher.Param("1234");
+            const field = new ParamInputField({
+                attribute,
+                attachedTo,
+                inputValue: callbackParam,
+            });
+            create.addField(field);
 
-                const callbackFunctionName = attribute.annotations.populatedBy?.callback;
-                if (!callbackFunctionName) {
-                    throw new Error(`PopulatedBy callback not found for attribute ${attribute.name}`);
-                }
+            const callbackFunctionName = attribute.annotations.populatedBy?.callback;
+            if (!callbackFunctionName) {
+                throw new Error(`PopulatedBy callback not found for attribute ${attribute.name}`);
+            }
 
-                callbackBucket.addCallback({
-                    functionName: callbackFunctionName,
-                    param: callbackParam,
-                    parent: input,
-                    type: attribute.type,
-                });
+            callbackBucket.addCallback({
+                functionName: callbackFunctionName,
+                param: callbackParam,
+                parent: input,
+                type: attribute.type,
             });
-        } else {
-            relationship?.getPopulatedByFields("CREATE").forEach((attribute) => {
+        });
+
+        if (relationship) {
+            relationship.getPopulatedByFields("CREATE").forEach((attribute) => {
                 const attachedTo = "relationship";
                 // the param value it's irrelevant as it will be overwritten by the callback function
                 const relCallbackParam = new Cypher.Param("");