Rename ignoreGeneratedLimit to disableGeneratedLimit

Author: angrykoala

.changeset/orange-apes-ring.md

@@ -2,4 +2,4 @@
 "@neo4j/graphql": patch
 ---
 
-Adds feature flag `cypherDirective.ignoreGeneratedLimit` to disable default limits to be applied on queries using `@cypher` directive
+Adds feature flag `cypherDirective.disableGeneratedLimit` to disable default limits to be applied on queries using `@cypher` directive

packages/graphql/src/translate/queryAST/factory/OperationFactory.ts

@@ -351,8 +351,8 @@ export class OperationsFactory {
                 const sort = this.sortAndPaginationFactory.createSortFields(sortOptions, entity, context);
                 operation.addSort(...sort);
 
-                // We don't want to generate the limit operation on custom cypher fields if the flag "ignoreGeneratedLimit" is set
-                if (operation instanceof CypherOperation && context.features.cypherDirective?.ignoreGeneratedLimit) {
+                // We don't want to generate the limit operation on custom cypher fields if the flag "disableGeneratedLimit" is set
+                if (operation instanceof CypherOperation && context.features.cypherDirective?.disableGeneratedLimit) {
                     return operation;
                 }
 

packages/graphql/src/types/index.ts

@@ -507,7 +507,7 @@ export type Neo4jFeaturesSettings = {
     /** Settings for the `@cypher` directive */
     cypherDirective?: {
         /** Enabling this setting, the limit generated by the directive `@limit` won't be added to fields with custom cypher */
-        ignoreGeneratedLimit?: boolean;
+        disableGeneratedLimit?: boolean;
     };
 };
 
@@ -519,7 +519,7 @@ export type ContextFeatures = {
     subscriptions?: Neo4jGraphQLSubscriptionsEngine;
     unsafeEscapeOptions?: Neo4jFeaturesSettings["unsafeEscapeOptions"];
     cypherDirective?: {
-        ignoreGeneratedLimit?: boolean;
+        disableGeneratedLimit?: boolean;
     };
 };
 

packages/graphql/tests/integration/directives/cypher/limit/cypher-with-ignore-limit.int.test.ts renamed to packages/graphql/tests/integration/directives/cypher/limit/cypher-with-disabled-limit.int.test.ts

@@ -20,7 +20,7 @@
 import type { UniqueType } from "../../../../utils/graphql-types";
 import { TestHelper } from "../../../../utils/tests-helper";
 
-describe("Cypher directive with limit ignoreGeneratedLimit flag", () => {
+describe("Cypher directive with limit disableGeneratedLimit flag", () => {
     const testHelper = new TestHelper();
     let typeDefs: string;
 
@@ -69,7 +69,7 @@ describe("Cypher directive with limit ignoreGeneratedLimit flag", () => {
             typeDefs,
             features: {
                 cypherDirective: {
-                    ignoreGeneratedLimit: true,
+                    disableGeneratedLimit: true,
                 },
             },
         });

packages/graphql/tests/tck/directives/cypher/limit/cypher-with-ignore-limit.test.ts renamed to packages/graphql/tests/tck/directives/cypher/limit/cypher-with-disabled-limit.test.ts

@@ -20,7 +20,7 @@
 import { Neo4jGraphQL } from "../../../../../src";
 import { formatCypher, formatParams, translateQuery } from "../../../utils/tck-test-utils";
 
-describe("Cypher directive with limit and ignoreGeneratedLimit flag", () => {
+describe("Cypher directive with limit and disableGeneratedLimit flag", () => {
     const typeDefs = /* GraphQL */ `
         type Tag @limit(default: 10, max: 100) @node {
             id: Int
@@ -59,7 +59,7 @@ describe("Cypher directive with limit and ignoreGeneratedLimit flag", () => {
         typeDefs,
         features: {
             cypherDirective: {
-                ignoreGeneratedLimit: true,
+                disableGeneratedLimit: true,
             },
         },
     });