Merge pull request #7027 from neo4j/7026-cypher-error-var-not-defined-when-using-totalcount-with-aggregations

fix #7026

Author: angrykoala

.changeset/short-paths-bet.md

@@ -0,0 +1,29 @@
+---
+"@neo4j/graphql": patch
+---
+
+Fix failing query when aggregation and totalCount is queried in a connection, but not edges. For example:
+
+```graphql
+type Actor @node {
+    name: String!
+}
+```
+
+```graphql
+query {
+    actorsConnection {
+        totalCount
+        aggregate {
+            node {
+                name {
+                    shortest
+                }
+            }
+            count {
+                nodes
+            }
+        }
+    }
+}
+```

packages/graphql/src/translate/queryAST/ast/operations/ConnectionReadOperation.ts

@@ -248,7 +248,10 @@ export class ConnectionReadOperation extends Operation {
         );
 
         if (aggregationSubqueries.length > 0) {
-            const returnClause = new Cypher.Return(edgesProjectionVar);
+            const returnClause = new Cypher.Return();
+            if (hasProjectionFields) {
+                returnClause.addColumns(edgesProjectionVar);
+            }
             if (this.hasTotalCount) {
                 returnClause.addColumns(totalCount);
             }

packages/graphql/tests/integration/issues/7026.int.test.ts

@@ -0,0 +1,88 @@
+/*
+ * Copyright (c) "Neo4j"
+ * Neo4j Sweden AB [http://neo4j.com]
+ *
+ * This file is part of Neo4j.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import type { UniqueType } from "../../utils/graphql-types";
+import { TestHelper } from "../../utils/tests-helper";
+
+describe("https://github.com/neo4j/graphql/issues/6917", () => {
+    let Actor: UniqueType;
+
+    const testHelper = new TestHelper();
+
+    beforeAll(async () => {
+        Actor = testHelper.createUniqueType("Actor");
+
+        const typeDefs = /* GraphQL */ `
+            type ${Actor} @node {
+                name: String!
+            }
+        `;
+
+        await testHelper.initNeo4jGraphQL({
+            typeDefs,
+        });
+
+        await testHelper.executeCypher(`
+            CREATE(:${Actor} {name: "Keanu"})
+            CREATE(:${Actor} {name: "Pepe"})
+        `);
+    });
+
+    afterAll(async () => {
+        await testHelper.close();
+    });
+
+    test("should return totalCount and aggregate, without edges", async () => {
+        const query = /* GraphQL */ `
+            query {
+                ${Actor.operations.connection} {
+                    totalCount
+                    aggregate {
+                        node {
+                            name {
+                                shortest
+                            }
+                        }
+                        count {
+                            nodes
+                        }
+                    }
+                }
+            }
+        `;
+
+        const result = await testHelper.executeGraphQL(query);
+        expect(result.errors).toBeUndefined();
+        expect(result.data as any).toEqual({
+            [Actor.operations.connection]: {
+                totalCount: 2,
+                aggregate: {
+                    node: {
+                        name: {
+                            shortest: "Pepe",
+                        },
+                    },
+                    count: {
+                        nodes: 2,
+                    },
+                },
+            },
+        });
+    });
+});