Fix all warnings in the driver project (#898)

* Fix all warnings in the driver project

* Fix null notifications

Author: RichardIrons-neo4j

Neo4j.Driver/Neo4j.Driver.Tests/Neo4j.Driver.Tests.csproj

@@ -14,7 +14,7 @@
         <GenerateAssemblyFileVersionAttribute>true</GenerateAssemblyFileVersionAttribute>
         <LangVersion>default</LangVersion>
         <Platforms>AnyCPU</Platforms>
-        <TargetFramework>net10.0</TargetFramework>
+        <TargetFrameworks>net10.0;net8.0;net9.0</TargetFrameworks>
     </PropertyGroup>
     <PropertyGroup Condition=" '$(Configuration)' == 'CI' ">
       <Optimize Condition=" '$(Optimize)' == '' ">true</Optimize>

Neo4j.Driver/Neo4j.Driver/Internal/Auth/DefaultTlsNegotiator.cs

@@ -24,6 +24,8 @@ internal sealed class DefaultTlsNegotiator : ITlsNegotiator
 {
     private readonly EncryptionManager _encryptionManager;
     private readonly INeo4jLogger _neo4JLogger;
+    private readonly IInternalX509CertificateLoader _internalX509CertificateLoader 
+        = new InternalX509CertificateLoader();
 
     public DefaultTlsNegotiator(INeo4jLogger neo4JLogger, EncryptionManager encryptionManager)
     {
@@ -45,9 +47,10 @@ public SslStream NegotiateTls(Uri uri, Stream stream)
                     return false;
                 }
 
+                var certData = certificate!.Export(X509ContentType.Cert);
                 var trust = _encryptionManager.TrustManager.ValidateServerCertificate(
                     uri,
-                    new X509Certificate2(certificate.Export(X509ContentType.Cert)),
+                    _internalX509CertificateLoader.LoadCertificate(certData),
                     chain,
                     errors);
 

Neo4j.Driver/Neo4j.Driver/Internal/Auth/IX509CertificateLoader.cs

@@ -0,0 +1,46 @@
+// Copyright (c) "Neo4j"
+// Neo4j Sweden AB [https://neo4j.com]
+// 
+// Licensed under the Apache License, Version 2.0 (the "License").
+// You may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+// 
+//     http://www.apache.org/licenses/LICENSE-2.0
+// 
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+using System.Security.Cryptography.X509Certificates;
+
+namespace Neo4j.Driver.Internal.Auth;
+
+internal interface IInternalX509CertificateLoader
+{
+    X509Certificate2 LoadCertificate(byte[] rawData);
+    X509Certificate2 LoadCertificate(string filename);
+}
+
+// this class is to hide away the conditional compilation for .NET >= 9
+internal class InternalX509CertificateLoader : IInternalX509CertificateLoader
+{
+    public X509Certificate2 LoadCertificate(byte[] rawData)
+    {
+#if NET9_0_OR_GREATER
+        return X509CertificateLoader.LoadCertificate(rawData);
+#else
+        return new X509Certificate2(rawData);
+#endif
+    }
+
+    public X509Certificate2 LoadCertificate(string filename)
+    {
+#if NET9_0_OR_GREATER
+        return X509CertificateLoader.LoadCertificateFromFile(filename);
+#else
+        return new X509Certificate2(filename);
+#endif
+    }
+}

Neo4j.Driver/Neo4j.Driver/Internal/ExceptionHandling/Neo4jExceptionFactory.cs

@@ -105,7 +105,8 @@ Neo4jException Factory(FailureMessage message, Exception inner)
     public Neo4jException GetException(FailureMessage failureMessage)
     {
         var factoryInfo =
-            _exceptionFactories.FirstOrDefault(f => _simpleWildcardHelper.StringMatches(failureMessage.Code, f.Code));
+            _exceptionFactories.FirstOrDefault(
+                f => _simpleWildcardHelper.StringMatches(failureMessage.CodeInternal, f.Code));
 
         if (factoryInfo is null)
         {

Neo4j.Driver/Neo4j.Driver/Internal/GqlCompliance/GqlErrors.cs

@@ -32,7 +32,7 @@ internal static class GqlErrors
 
     public static void FillGqlDefaults(FailureMessage message)
     {
-        message.Code ??= UnknownNeo4JCode;
+        message.CodeInternal ??= UnknownNeo4JCode;
         message.Message ??= UnknownMessage;
         message.GqlStatus ??= UnknownGqlStatus;
 

Neo4j.Driver/Neo4j.Driver/Internal/IO/MessageSerializers/FailureMessageSerializer.cs

@@ -56,7 +56,7 @@ internal static FailureMessage BuildFailureMessage(IReadOnlyDictionary<string, o
             {
                 case "neo4j_code":
                 case "code":
-                    response.Code = FixCodeForBolt5(majorVersion, value?.ToString() ?? string.Empty);
+                    response.CodeInternal = FixCodeForBolt5(majorVersion, value?.ToString() ?? string.Empty);
                     break;
 
                 case "message":

Neo4j.Driver/Neo4j.Driver/Internal/IO/PackStreamBitConverter.cs

@@ -77,7 +77,7 @@ public static byte[] GetBytes(long value)
 
     /// <summary>Converts a float (Float32) to bytes.</summary>
     /// <param name="value">The float (Float32) value to convert.</param>
-    /// <returns>The specified float (Float32) value as an array of bytes.</returns
+    /// <returns>The specified float (Float32) value as an array of bytes.</returns>
     public static byte[] GetBytes(float value)
     {
         var bytes = BitConverter.GetBytes(value);

Neo4j.Driver/Neo4j.Driver/Internal/MessageHandling/Metadata/GqlStatusObjectsAndNotifications.cs

@@ -21,7 +21,7 @@
 namespace Neo4j.Driver.Internal.MessageHandling.Metadata;
 
 internal sealed record GqlStatusObjectsAndNotifications(
-    IList<INotification> Notifications,
+    IList<Notification> Notifications,
     IList<IGqlStatusObject> GqlStatusObjects,
     bool UseRawStatuses)
 {
@@ -62,7 +62,7 @@ private static string GetStatusOrderingValue(IGqlStatusObject x)
         return status?.Length > 1 ? status.Substring(0, 2) : "";
     }
 
-    public IList<INotification> FinalizeNotifications(CursorMetadata cursorMetadata)
+    public IList<Notification> FinalizeNotifications(CursorMetadata cursorMetadata)
     {
         return Notifications;
     }

Neo4j.Driver/Neo4j.Driver/Internal/MessageHandling/Metadata/GqlStatusObjectsAndNotificationsCollector.cs

@@ -71,7 +71,7 @@ private static IList<T> ConvertObjects<T>(
         return null;
     }
 
-    private static INotification ConvertNotification(IDictionary<string, object> notification)
+    private static Notification ConvertNotification(IDictionary<string, object> notification)
     {
         var code = notification.GetValue("code", string.Empty);
         var title = notification.GetValue("title", string.Empty);
@@ -160,7 +160,7 @@ private static IGqlStatusObject ConvertNotificationValuesToStatus(IDictionary<st
             !string.IsNullOrEmpty(code));
     }
 
-    private static INotification ConvertStatusValuesToNotification(IDictionary<string, object> gqlStatus)
+    private static Notification ConvertStatusValuesToNotification(IDictionary<string, object> gqlStatus)
     {
         var code = gqlStatus.GetValue<string>("neo4j_code", null);
         if (code == null)

Neo4j.Driver/Neo4j.Driver/Internal/MessageHandling/ResponsePipeline.cs

@@ -81,7 +81,7 @@ public void OnRecord(object[] fieldValues)
 
     public void OnFailure(FailureMessage failureMessage)
     {
-        LogFailure(failureMessage.Code, failureMessage.Message);
+        LogFailure(failureMessage.CodeInternal, failureMessage.Message);
         var handler = Dequeue();
         _error = new ResponsePipelineError(ErrorExtensions.ParseServerException(failureMessage));
         handler.OnFailure(_error);