handle int values for required property

Author: AmirLayegh

src/neo4j_graphrag/experimental/components/schema.py

@@ -693,33 +693,26 @@ def _filter_properties_required_field(
                 prop_name = prop.get("name", "unknown")
                 node_label = node_type.get("label", "unknown")
 
-                if isinstance(required_value, str):
-                    if required_value.lower() in ("true", "yes", "1"):
-                        prop["required"] = True
-                        logging.info(
-                            f"Converted 'required' value {required_value} to True "
-                            f"for property '{prop_name}' on node '{node_label}'"
-                        )
-                    elif required_value.lower() in ("false", "no", "0"):
-                        prop["required"] = False
-                        logging.info(
-                            f"Converted 'required' value '{required_value}' to False "
-                            f"for property '{prop_name}' on node '{node_label}' "
-                        )
-                    # Unknown string values
-                    else:
-                        logging.info(
-                            f"Removing unrecognized 'required' value '{required_value}' "
-                            f"for property '{prop_name}' on node '{node_label}'. "
-                            f"Using default (False) "  # TODO: Not sure if we have to convert it to the default value - double check!
-                        )
-                        prop.pop("required", None)
+                # Convert to string to handle int values like 1 or 0
+                required_str = str(required_value).lower()
+
+                if required_str in ("true", "yes", "1"):
+                    prop["required"] = True
+                    logging.info(
+                        f"Converted 'required' value '{required_value}' to True "
+                        f"for property '{prop_name}' on node '{node_label}'"
+                    )
+                elif required_str in ("false", "no", "0"):
+                    prop["required"] = False
+                    logging.info(
+                        f"Converted 'required' value '{required_value}' to False "
+                        f"for property '{prop_name}' on node '{node_label}'"
+                    )
                 else:
-                    # Non-string, non-boolean - remove
                     logging.info(
-                        f"Removing invalid 'required' value '{required_value}' (type: {type(required_value).__name__}) "
+                        f"Removing unrecognized 'required' value '{required_value}' "
                         f"for property '{prop_name}' on node '{node_label}'. "
-                        f"Using default (False). "
+                        f"Using default (False)."
                     )
                     prop.pop("required", None)
 
@@ -743,7 +736,7 @@ def _enforce_required_for_constraint_properties(
                 if label and prop:
                     constraint_props.setdefault(label, set()).add(prop)
 
-        # Skop node_types without constraints
+        # Skip node_types without constraints
         for node_type in node_types:
             label = node_type.get("label")
             if label not in constraint_props:

tests/unit/experimental/components/test_schema.py

@@ -1536,16 +1536,34 @@ def test_filter_properties_required_field_invalid_string(
     assert "required" not in result[0]["properties"][1]
 
 
-def test_filter_properties_required_field_invalid_type(
+def test_filter_properties_required_field_int_values(
     schema_from_text: SchemaFromTextExtractor,
 ) -> None:
+    """Test that int values like 1 and 0 are converted to True/False."""
     node_types = [
         {
             "label": "Person",
             "properties": [
                 {"name": "prop1", "type": "STRING", "required": 1},
-                {"name": "prop2", "type": "STRING", "required": []},
-                {"name": "prop3", "type": "STRING", "required": {"value": True}},
+                {"name": "prop2", "type": "STRING", "required": 0},
+            ],
+        }
+    ]
+    result = schema_from_text._filter_properties_required_field(node_types)
+    assert result[0]["properties"][0]["required"] is True
+    assert result[0]["properties"][1]["required"] is False
+
+
+def test_filter_properties_required_field_invalid_type(
+    schema_from_text: SchemaFromTextExtractor,
+) -> None:
+    """Test that unrecognized types like list and dict are removed."""
+    node_types = [
+        {
+            "label": "Person",
+            "properties": [
+                {"name": "prop1", "type": "STRING", "required": []},
+                {"name": "prop2", "type": "STRING", "required": {"value": True}},
             ],
         }
     ]