Skip to content

Commit 01d71de

Browse files
committed
Don't pass metadata object to users onCompleted.
- Users should use result.summarize() to get metadata.
1 parent 577b8f6 commit 01d71de

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ session.run(statement.join(' '), params).subscribe({
4646
for(var i in record) {
4747
console.log(i, ': ', record[i]);
4848
}
49-
}, onCompleted: function(metadata) {
50-
console.log(metadata);
49+
}, onCompleted: function() {
50+
session.close();
5151
}, onError: function(error) {
5252
console.log(error);
5353
}
@@ -61,7 +61,8 @@ session.run(statement.join(' '), params)
6161
for(var i in record) {
6262
console.log(i, ': ', record[i]);
6363
}
64-
})
64+
});
65+
session.close();
6566
})
6667
.catch(function(error) {
6768
console.log(error);

lib/result.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ class Result {
9494
let onCompletedOriginal = observer.onCompleted;
9595
let onCompletedWrapper = (metadata) => {
9696
this.summary = new ResultSummary(this._statement, this._parameters, metadata);
97-
onCompletedOriginal.call(observer, metadata);
97+
onCompletedOriginal.call(observer);
9898
}
9999
observer.onCompleted = onCompletedWrapper;
100100
this._streamObserver.subscribe(observer);

0 commit comments

Comments
 (0)