Add a test for retries on unknown exceptions

Author: ali-ince

src/v1/internal/transaction-executor.js

@@ -17,7 +17,12 @@
  * limitations under the License.
  */
 
-import { newError, Neo4jError, SERVICE_UNAVAILABLE, SESSION_EXPIRED } from '../error'
+import {
+  newError,
+  Neo4jError,
+  SERVICE_UNAVAILABLE,
+  SESSION_EXPIRED
+} from '../error'
 
 const DEFAULT_MAX_RETRY_TIME_MS = 30 * 1000 // 30 seconds
 const DEFAULT_INITIAL_RETRY_DELAY_MS = 1000 // 1 seconds

test/internal/transaction-executor.test.js

@@ -91,6 +91,23 @@ describe('TransactionExecutor', () => {
     testNoRetryOnUnknownError([LOCKS_TERMINATED_ERROR], 1, done)
   })
 
+  it('should not retry when transaction work returns promise rejected with unknown error type', async () => {
+    class MyTestError extends Error {
+      constructor (message, code) {
+        super(message)
+        this.code = code
+      }
+    }
+
+    const error = new MyTestError('an unexpected error', 504)
+    const executor = new TransactionExecutor()
+    const realWork = () => Promise.reject(error)
+
+    await expectAsync(
+      executor.execute(transactionCreator(), tx => realWork())
+    ).toBeRejectedWith(error)
+  })
+
   it('should stop retrying when time expires', done => {
     const executor = new TransactionExecutor()
     const usedTransactions = []