Skip to content

Commit 83bf5b3

Browse files
committed
Remove prepublish
For insane reasons, NPM crew chose to make `prepublish` trigger both on `npm publish` and on (some cases of) `npm install`, rather than having a special hook for local installs. Since we want CI to build things once and then test those same artifacts throughout the the whole QA pipeline, we do not want to rebuild the project right before deploy, and thus do not want the prepublish hook. I was going to just sed out prepublish in CI, until I realized that prepublish only triggers if you manually `git checkout <repo> && npm install`, it does not trigger if you do `npm install <repo>`, which seems to be the idiomatic pattern. Hence, prepublish is inconsistent and gets in the way of CI. People that manually `git checkout` can simply `npm build`. We will need to address `npm install <repo>` somehow - and we should find a way to do it that means we don't need to keep a built version of the library checked into the code base.
1 parent 4523a52 commit 83bf5b3

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
"build": "gulp all",
1414
"start-neo4j": "gulp start-neo4j",
1515
"stop-neo4j": "gulp stop-neo4j",
16-
"prepublish": "npm run build",
1716
"docs": "node_modules/.bin/esdoc -c esdoc.json"
1817
},
1918
"main": "lib/neo4j.js",

0 commit comments

Comments
 (0)