Add tests to verify connection error on commit behavior

Author: ali-ince

test/internal/node/direct.driver.boltkit.test.js

@@ -20,6 +20,7 @@
 import neo4j from '../../../src/v1';
 import {READ, WRITE} from '../../../src/v1/driver';
 import boltStub from '../bolt-stub';
+import { SERVICE_UNAVAILABLE } from '../../../src/v1/error';
 
 describe('direct driver with stub server', () => {
 
@@ -372,4 +373,46 @@ describe('direct driver with stub server', () => {
       }).catch(error => done.fail(error));
     });
   });
+
+  describe('should fail if commit fails due to broken connection', () => {
+    it('v1', done => {
+      verifyFailureOnConnectionFailureWhenExplicitTransactionIsCommitted('v1', done);
+    });
+
+    it('v3', done => {
+      verifyFailureOnConnectionFailureWhenExplicitTransactionIsCommitted('v3', done);
+    });
+  });
+
+  function verifyFailureOnConnectionFailureWhenExplicitTransactionIsCommitted(version, done) {
+    if (!boltStub.supported) {
+      done();
+      return;
+    }
+
+    const server = boltStub.start(`./test/resources/boltstub/connection_error_on_commit_${version}.script`, 9001);
+
+    boltStub.run(() => {
+        const driver = boltStub.newDriver('bolt://127.0.0.1:9001');
+        const session = driver.session();
+
+        const writeTx = session.beginTransaction();
+
+        writeTx.run('CREATE (n {name: \'Bob\'})').then(() =>
+          writeTx.commit().then(result => fail('expected an error'), (error) => {
+            expect(error.code).toBe(SERVICE_UNAVAILABLE);
+            expect(error.message).toContain('Connection was closed by server');
+          })
+        ).finally(() =>
+          session.close(() => {
+            driver.close();
+
+            server.exit(code => {
+              expect(code).toEqual(0);
+              done();
+            });
+          })).catch(error => done.fail(error));
+      }
+    );
+  }
 });

test/resources/boltstub/connection_error_on_commit_v1.script

@@ -0,0 +1,15 @@
+!: BOLT 1
+!: AUTO INIT
+!: AUTO RESET
+
+C: RUN "BEGIN" {}
+   PULL_ALL
+   RUN "CREATE (n {name: 'Bob'})" {}
+   PULL_ALL
+S: SUCCESS {}
+   SUCCESS {}
+   SUCCESS {}
+   SUCCESS {}
+C: RUN "COMMIT" {}
+   PULL_ALL
+S: <EXIT>

test/resources/boltstub/connection_error_on_commit_v3.script

@@ -0,0 +1,12 @@
+!: BOLT 3
+!: AUTO HELLO
+!: AUTO RESET
+
+C: BEGIN {}
+S: SUCCESS {}
+C: RUN "CREATE (n {name: 'Bob'})" {} {}
+   PULL_ALL
+S: SUCCESS {}
+   SUCCESS {}
+C: COMMIT
+S: <EXIT>