Skip to content

Commit 7e9a2b7

Browse files
authored
Merge pull request #188 from neo4j/drop-temp-internal-props
Make sure to drop temp internal node props in `from_gds`
2 parents 52b18e4 + 47592d8 commit 7e9a2b7

File tree

3 files changed

+9
-0
lines changed

3 files changed

+9
-0
lines changed

changelog.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313

1414
## Bug fixes
1515

16+
* Make sure that temporary internal node properties are not included in the visualization output.
17+
1618

1719
## Improvements
1820

python-wrapper/src/neo4j_viz/gds.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,10 @@ def from_gds(
119119
node_properties = [property_name]
120120

121121
node_dfs = _fetch_node_dfs(gds, G_fetched, node_properties, G_fetched.node_labels())
122+
if property_name is not None:
123+
for df in node_dfs.values():
124+
df.drop(columns=[property_name], inplace=True)
125+
122126
rel_df = _fetch_rel_df(gds, G_fetched)
123127
finally:
124128
if G_fetched.name() != G.name():

python-wrapper/tests/test_gds.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -276,6 +276,9 @@ def test_from_gds_sample(gds: Any) -> None:
276276
):
277277
VG = from_gds(gds, G)
278278

279+
# Make sure internal temporary properties are not present
280+
assert set(VG.nodes[0].properties.keys()) == {"labels"}
281+
279282
assert len(VG.nodes) >= 9_500
280283
assert len(VG.nodes) <= 10_500
281284
assert len(VG.relationships) >= 9_500

0 commit comments

Comments
 (0)