Skip to content

Generic naming of the choose module button with just numbers can cause event collisions with other scenarios/mods that do the same #1

@Soggs

Description

@Soggs

I ran into this issue with our Redmew scenario and Module Inserter. I have since fixed the Redmew side of things but I though I should also let you know of it to prevent possible issues in the future.

In that specific case clicking the second module button in the MI Interface would also trigger the event to show/close our scenario info screen. Short video of that here: https://cdn.discordapp.com/attachments/306402592265732098/952640374973812746/2022-03-13_19-47-00.mp4

This happend as both buttons where generically named 2 so they reacted to the on_gui_click event from a button named 2.

I have a Pull Request ready and will attach it to this issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions