-
-
Notifications
You must be signed in to change notification settings - Fork 8
Description
Specifically neoforged/NeoForge#2547 made the install process run faster and consume more memory, about 350mb. Unfortunately the max default heap provided by 32 bit java is 250mb so the installer errors with an out of memory error, which doesn't tell the average user much useful information.
This is not an error that's rare, unfortunately it seems there is a decent proportion of people still running 32 bit java. See these examples from the past couple weeks:
neoforged/NeoForge#2786 created after https://discord.com/channels/313125603924639766/437001959950778368/1434506046529081425
https://discord.com/channels/313125603924639766/437001959950778368/1439136695613390858
https://discord.com/channels/313125603924639766/437001959950778368/1437416252309110886
https://discord.com/channels/313125603924639766/437001959950778368/1437417931062509628
https://discord.com/channels/313125603924639766/437001959950778368/1437191478689661090
https://discord.com/channels/313125603924639766/437001959950778368/1441127744535658689
(Discord links from NeoForge discords #user-support channel)
Ideally the installer should detect if its running with too little memory/if its running on 32 bit java (probably combine both in an AND condition) and display a useful error advising the user to install a modern java version.