Skip to content

Commit 4f88afa

Browse files
authored
Fix RemapJar producing broken jars if any copy spec is provided to the underlying Jar task (#219)
1 parent 1a81e72 commit 4f88afa

File tree

1 file changed

+12
-3
lines changed
  • src/legacy/java/net/neoforged/moddevgradle/legacyforge/tasks

1 file changed

+12
-3
lines changed

src/legacy/java/net/neoforged/moddevgradle/legacyforge/tasks/RemapJar.java

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
package net.neoforged.moddevgradle.legacyforge.tasks;
22

3+
import java.io.File;
34
import java.io.IOException;
5+
import java.io.UncheckedIOException;
46
import javax.inject.Inject;
57
import org.gradle.api.file.ConfigurableFileCollection;
68
import org.gradle.api.file.RegularFileProperty;
@@ -33,10 +35,17 @@ public abstract class RemapJar extends Jar {
3335
protected abstract ExecOperations getExecOperations();
3436

3537
@Inject
36-
public RemapJar() {}
38+
public RemapJar() {
39+
getRemapOperation().getLogFile().set(new File(getTemporaryDir(), "console.log"));
40+
}
3741

3842
@TaskAction
39-
public void remap() throws IOException {
40-
getRemapOperation().execute(getExecOperations(), getInput().getAsFile().get(), getArchiveFile().get().getAsFile(), getLibraries());
43+
@Override
44+
public void copy() {
45+
try {
46+
getRemapOperation().execute(getExecOperations(), getInput().getAsFile().get(), getArchiveFile().get().getAsFile(), getLibraries());
47+
} catch (IOException e) {
48+
throw new UncheckedIOException(e);
49+
}
4150
}
4251
}

0 commit comments

Comments
 (0)