Skip to content

Commit d51a7f0

Browse files
committed
Warn for Modrinth maven too
1 parent c14114b commit d51a7f0

File tree

1 file changed

+6
-0
lines changed
  • src/main/java/net/neoforged/moddevgradle/tasks

1 file changed

+6
-0
lines changed

src/main/java/net/neoforged/moddevgradle/tasks/JarJar.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,12 @@ protected void run() throws IOException {
111111
getLogger().warn("Embedding dependency {}:{}:{} from cursemaven using JiJ is likely to cause conflicts at runtime when other mods include the same library from a normal Maven repository.",
112112
includedJar.getGroup(), includedJar.getArtifact(), includedJar.getVersion());
113113
}
114+
// Same with the Modrinth official maven (see https://support.modrinth.com/en/articles/8801191-modrinth-maven)
115+
// While actual versions can be used, version IDs (which are random strings) can also be used
116+
else if ("maven.modrinth".equals(includedJar.getGroup())) {
117+
getLogger().warn("Embedding dependency {}:{}:{} from Modrinth Maven using JiJ is likely to cause conflicts at runtime when other mods include the same library from a normal Maven repository.",
118+
includedJar.getGroup(), includedJar.getArtifact(), includedJar.getVersion());
119+
}
114120

115121
var originalName = includedJar.getFile().getName();
116122
var embeddedName = includedJar.getEmbeddedFilename();

0 commit comments

Comments
 (0)