Skip to content

Commit ebf5b8c

Browse files
authored
Align source formatting with the NeoForge project code style (#214)
1 parent 9163863 commit ebf5b8c

File tree

79 files changed

+582
-802
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

79 files changed

+582
-802
lines changed

src/generated/java/net/neoforged/moddevgradle/internal/generated/MinecraftVersionList.java

Lines changed: 22 additions & 11 deletions
Large diffs are not rendered by default.

src/java8/java/net/neoforged/moddevgradle/boot/TrampolinePlugin.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
package net.neoforged.moddevgradle.boot;
22

3+
import java.util.regex.Matcher;
4+
import java.util.regex.Pattern;
35
import org.gradle.api.GradleException;
46
import org.gradle.api.Plugin;
57
import org.gradle.api.plugins.PluginAware;
68
import org.gradle.util.GradleVersion;
79

8-
import java.util.regex.Matcher;
9-
import java.util.regex.Pattern;
10-
1110
/**
1211
* This is just a trampoline to perform the Java and Gradle version check, and is compiled for Java 8 in the real Jar.
1312
*/
@@ -32,7 +31,7 @@ public final void apply(T target) {
3231

3332
if (GradleVersion.current().compareTo(MIN_GRADLE_VERSION) < 0) {
3433
throw new GradleException("To use the NeoForge plugin, please use at least " + MIN_GRADLE_VERSION
35-
+ ". You are currently using " + GradleVersion.current() + ".");
34+
+ ". You are currently using " + GradleVersion.current() + ".");
3635
}
3736

3837
try {

src/legacy/java/net/neoforged/moddevgradle/legacyforge/dsl/LegacyForgeExtension.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
package net.neoforged.moddevgradle.legacyforge.dsl;
22

3+
import javax.inject.Inject;
34
import net.neoforged.moddevgradle.dsl.DataFileCollection;
45
import net.neoforged.moddevgradle.dsl.ModDevExtension;
56
import net.neoforged.moddevgradle.legacyforge.internal.LegacyForgeModDevPlugin;
67
import org.gradle.api.Action;
78
import org.gradle.api.Project;
89

9-
import javax.inject.Inject;
10-
1110
/**
1211
* This is the top-level {@code legacyForge} extension, used to configure the moddev plugin.
1312
*/
@@ -16,8 +15,8 @@ public abstract class LegacyForgeExtension extends ModDevExtension {
1615

1716
@Inject
1817
public LegacyForgeExtension(Project project,
19-
DataFileCollection accessTransformers,
20-
DataFileCollection interfaceInjectionData) {
18+
DataFileCollection accessTransformers,
19+
DataFileCollection interfaceInjectionData) {
2120
super(project, accessTransformers, interfaceInjectionData);
2221
this.project = project;
2322
}

src/legacy/java/net/neoforged/moddevgradle/legacyforge/dsl/LegacyForgeModdingSettings.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
11
package net.neoforged.moddevgradle.legacyforge.dsl;
22

3+
import java.util.HashSet;
4+
import java.util.Set;
5+
import javax.inject.Inject;
36
import net.neoforged.moddevgradle.internal.utils.ExtensionUtils;
47
import org.gradle.api.Project;
58
import org.gradle.api.tasks.SourceSet;
69
import org.jetbrains.annotations.Nullable;
710

8-
import javax.inject.Inject;
9-
import java.util.HashSet;
10-
import java.util.Set;
11-
1211
public abstract class LegacyForgeModdingSettings {
1312
@Nullable
1413
private String neoForgeVersion;

src/legacy/java/net/neoforged/moddevgradle/legacyforge/dsl/MixinCompilerArgs.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,17 @@
11
package net.neoforged.moddevgradle.legacyforge.dsl;
22

3+
import java.util.List;
4+
import javax.inject.Inject;
35
import org.gradle.api.file.RegularFileProperty;
46
import org.gradle.api.tasks.InputFile;
57
import org.gradle.api.tasks.OutputFile;
68
import org.gradle.api.tasks.PathSensitive;
79
import org.gradle.api.tasks.PathSensitivity;
810
import org.gradle.process.CommandLineArgumentProvider;
911

10-
import javax.inject.Inject;
11-
import java.util.List;
12-
1312
abstract class MixinCompilerArgs implements CommandLineArgumentProvider {
1413
@Inject
15-
public MixinCompilerArgs() {
16-
}
14+
public MixinCompilerArgs() {}
1715

1816
@OutputFile
1917
protected abstract RegularFileProperty getOutMappings();
@@ -36,7 +34,6 @@ public Iterable<String> asArguments() {
3634
"-AoutRefMapFile=" + getRefmap().get().getAsFile().getAbsolutePath(),
3735
"-AmappingTypes=tsrg",
3836
"-ApluginVersion=0.7", // Not sure what this is used for, but MixinGradle gives it to the AP. Latest as of time of writing
39-
"-AdefaultObfuscationEnv=searge"
40-
);
37+
"-AdefaultObfuscationEnv=searge");
4138
}
4239
}

src/legacy/java/net/neoforged/moddevgradle/legacyforge/dsl/MixinExtension.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package net.neoforged.moddevgradle.legacyforge.dsl;
22

3+
import javax.inject.Inject;
34
import org.gradle.api.Project;
45
import org.gradle.api.file.ConfigurableFileCollection;
56
import org.gradle.api.file.RegularFile;
@@ -9,17 +10,15 @@
910
import org.gradle.api.tasks.compile.JavaCompile;
1011
import org.gradle.jvm.tasks.Jar;
1112

12-
import javax.inject.Inject;
13-
1413
public abstract class MixinExtension {
1514
private final Project project;
1615
private final Provider<RegularFile> officialToSrg;
1716
private final ConfigurableFileCollection extraMappingFiles;
1817

1918
@Inject
2019
public MixinExtension(Project project,
21-
Provider<RegularFile> officialToSrg,
22-
ConfigurableFileCollection extraMappingFiles) {
20+
Provider<RegularFile> officialToSrg,
21+
ConfigurableFileCollection extraMappingFiles) {
2322
this.project = project;
2423
this.officialToSrg = officialToSrg;
2524
this.extraMappingFiles = extraMappingFiles;
@@ -54,4 +53,3 @@ public Provider<RegularFile> add(SourceSet sourceSet, String refmap) {
5453
return refMapFile;
5554
}
5655
}
57-

src/legacy/java/net/neoforged/moddevgradle/legacyforge/dsl/ObfuscationExtension.java

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
package net.neoforged.moddevgradle.legacyforge.dsl;
22

3+
import java.util.List;
4+
import java.util.Objects;
5+
import javax.inject.Inject;
36
import net.neoforged.moddevgradle.legacyforge.internal.MinecraftMappings;
47
import net.neoforged.moddevgradle.legacyforge.tasks.RemapJar;
58
import net.neoforged.moddevgradle.legacyforge.tasks.RemapOperation;
@@ -23,10 +26,6 @@
2326
import org.gradle.api.tasks.bundling.AbstractArchiveTask;
2427
import org.jetbrains.annotations.ApiStatus;
2528

26-
import javax.inject.Inject;
27-
import java.util.List;
28-
import java.util.Objects;
29-
3029
public abstract class ObfuscationExtension {
3130
private final Project project;
3231
private final Configuration autoRenamingToolRuntime;
@@ -35,9 +34,9 @@ public abstract class ObfuscationExtension {
3534

3635
@Inject
3736
public ObfuscationExtension(Project project,
38-
Configuration autoRenamingToolRuntime,
39-
Configuration installerToolsRuntime,
40-
FileCollection extraMixinMappings) {
37+
Configuration autoRenamingToolRuntime,
38+
Configuration installerToolsRuntime,
39+
FileCollection extraMixinMappings) {
4140
this.project = project;
4241
this.autoRenamingToolRuntime = autoRenamingToolRuntime;
4342
this.installerToolsRuntime = installerToolsRuntime;
@@ -79,13 +78,12 @@ public void configureSrgToNamedOperation(RemapOperation operation) {
7978
/**
8079
* Create a reobfuscation task.
8180
*
82-
* @param jar the jar task to reobfuscate
83-
* @param sourceSet the source set whose classpath to use when remapping inherited methods
81+
* @param jar the jar task to reobfuscate
82+
* @param sourceSet the source set whose classpath to use when remapping inherited methods
8483
* @return a provider of the created task
8584
*/
8685
public TaskProvider<RemapJar> reobfuscate(TaskProvider<? extends AbstractArchiveTask> jar, SourceSet sourceSet) {
87-
return reobfuscate(jar, sourceSet, ignored -> {
88-
});
86+
return reobfuscate(jar, sourceSet, ignored -> {});
8987
}
9088

9189
/**
@@ -97,8 +95,8 @@ public TaskProvider<RemapJar> reobfuscate(TaskProvider<? extends AbstractArchive
9795
* @return a provider of the created task
9896
*/
9997
public TaskProvider<RemapJar> reobfuscate(TaskProvider<? extends AbstractArchiveTask> jar,
100-
SourceSet sourceSet,
101-
Action<RemapJar> configureTask) {
98+
SourceSet sourceSet,
99+
Action<RemapJar> configureTask) {
102100
var reobf = project.getTasks().register("reobf" + StringUtils.capitalize(jar.getName()), RemapJar.class, task -> {
103101
task.getInput().set(jar.flatMap(AbstractArchiveTask::getArchiveFile));
104102
task.getDestinationDirectory().convention(task.getProject().getLayout().getBuildDirectory().dir("libs"));
@@ -139,8 +137,7 @@ public TaskProvider<RemapJar> reobfuscate(TaskProvider<? extends AbstractArchive
139137

140138
// Publish the reobf configuration instead of the original one to Maven
141139
java.withVariantsFromConfiguration(config, ConfigurationVariantDetails::skip);
142-
java.addVariantsFromConfiguration(reobfConfig, spec -> {
143-
});
140+
java.addVariantsFromConfiguration(reobfConfig, spec -> {});
144141
}
145142

146143
return reobf;

src/legacy/java/net/neoforged/moddevgradle/legacyforge/internal/LegacyForgeMetadataTransform.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
import com.google.gson.JsonElement;
44
import com.google.gson.JsonObject;
5+
import java.util.List;
6+
import javax.inject.Inject;
57
import org.gradle.api.Action;
68
import org.gradle.api.artifacts.CacheableRule;
79
import org.gradle.api.artifacts.ComponentMetadataContext;
@@ -14,9 +16,6 @@
1416
import org.gradle.api.attributes.Usage;
1517
import org.gradle.api.model.ObjectFactory;
1618

17-
import javax.inject.Inject;
18-
import java.util.List;
19-
2019
@CacheableRule
2120
class LegacyForgeMetadataTransform extends LegacyMetadataTransform {
2221
@Inject

src/legacy/java/net/neoforged/moddevgradle/legacyforge/internal/LegacyForgeModDevPlugin.java

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,16 @@
11
package net.neoforged.moddevgradle.legacyforge.internal;
22

3+
import java.net.URI;
4+
import java.util.stream.Stream;
35
import net.neoforged.minecraftdependencies.MinecraftDependenciesPlugin;
46
import net.neoforged.moddevgradle.internal.ArtifactNamingStrategy;
57
import net.neoforged.moddevgradle.internal.Branding;
68
import net.neoforged.moddevgradle.internal.DataFileCollections;
7-
import net.neoforged.moddevgradle.internal.ModdingDependencies;
8-
import net.neoforged.moddevgradle.internal.jarjar.JarJarPlugin;
99
import net.neoforged.moddevgradle.internal.ModDevArtifactsWorkflow;
1010
import net.neoforged.moddevgradle.internal.ModDevRunWorkflow;
11+
import net.neoforged.moddevgradle.internal.ModdingDependencies;
1112
import net.neoforged.moddevgradle.internal.RepositoriesPlugin;
13+
import net.neoforged.moddevgradle.internal.jarjar.JarJarPlugin;
1214
import net.neoforged.moddevgradle.internal.utils.ExtensionUtils;
1315
import net.neoforged.moddevgradle.internal.utils.VersionCapabilitiesInternal;
1416
import net.neoforged.moddevgradle.legacyforge.dsl.LegacyForgeExtension;
@@ -30,9 +32,6 @@
3032
import org.slf4j.Logger;
3133
import org.slf4j.LoggerFactory;
3234

33-
import java.net.URI;
34-
import java.util.stream.Stream;
35-
3635
@ApiStatus.Internal
3736
public class LegacyForgeModDevPlugin implements Plugin<Project> {
3837
private static final Logger LOG = LoggerFactory.getLogger(LegacyForgeModDevPlugin.class);
@@ -102,8 +101,7 @@ public void apply(Project project) {
102101
LegacyForgeExtension.class,
103102
project,
104103
dataFileCollections.accessTransformers().extension(),
105-
dataFileCollections.interfaceInjectionData().extension()
106-
);
104+
dataFileCollections.interfaceInjectionData().extension());
107105
}
108106

109107
public void enable(Project project, LegacyForgeModdingSettings settings, LegacyForgeExtension extension) {
@@ -151,15 +149,13 @@ public void enable(Project project, LegacyForgeModdingSettings settings, LegacyF
151149
artifactNamingStrategy,
152150
configurations.getByName(DataFileCollections.CONFIGURATION_ACCESS_TRANSFORMERS),
153151
configurations.getByName(DataFileCollections.CONFIGURATION_INTERFACE_INJECTION_DATA),
154-
versionCapabilities
155-
);
152+
versionCapabilities);
156153

157154
var runs = ModDevRunWorkflow.create(
158155
project,
159156
Branding.MDG,
160157
artifacts,
161-
extension.getRuns()
162-
);
158+
extension.getRuns());
163159

164160
// Configure the mixin and obfuscation extensions
165161
var mixin = ExtensionUtils.getExtension(project, MIXIN_EXTENSION, MixinExtension.class);
@@ -185,8 +181,7 @@ public void enable(Project project, LegacyForgeModdingSettings settings, LegacyF
185181

186182
var reobfJar = obf.reobfuscate(
187183
project.getTasks().named(JavaPlugin.JAR_TASK_NAME, Jar.class),
188-
project.getExtensions().getByType(SourceSetContainer.class).getByName(SourceSet.MAIN_SOURCE_SET_NAME)
189-
);
184+
project.getExtensions().getByType(SourceSetContainer.class).getByName(SourceSet.MAIN_SOURCE_SET_NAME));
190185

191186
project.getTasks().named("assemble", assemble -> assemble.dependsOn(reobfJar));
192187

src/legacy/java/net/neoforged/moddevgradle/legacyforge/internal/LegacyMetadataTransform.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,16 @@
22

33
import com.google.gson.Gson;
44
import com.google.gson.JsonObject;
5+
import java.io.BufferedInputStream;
6+
import java.io.IOException;
7+
import java.nio.charset.StandardCharsets;
8+
import java.util.jar.JarInputStream;
59
import org.gradle.api.GradleException;
610
import org.gradle.api.artifacts.ComponentMetadataContext;
711
import org.gradle.api.artifacts.ComponentMetadataRule;
812
import org.gradle.api.artifacts.repositories.RepositoryResourceAccessor;
913
import org.gradle.api.model.ObjectFactory;
1014

11-
import java.io.BufferedInputStream;
12-
import java.io.IOException;
13-
import java.nio.charset.StandardCharsets;
14-
import java.util.jar.JarInputStream;
15-
1615
abstract class LegacyMetadataTransform implements ComponentMetadataRule {
1716
protected final ObjectFactory objects;
1817
private final RepositoryResourceAccessor repositoryResourceAccessor;

0 commit comments

Comments
 (0)