Support for 26.1 / unobfuscated Minecraft #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last commit published: 4d114eaec60d838bee65c584d398b580a95c9344 - version: PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name = "Maven for PR #298" // https://github.com/neoforged/ModDevGradle/pull/298
url = uri("https://prmaven.neoforged.net/ModDevGradle/pr298")
content {
includeModule("net.neoforged.moddev.legacyforge", "net.neoforged.moddev.legacyforge.gradle.plugin")
includeModule("net.neoforged.moddev.legacyforge.repositories", "net.neoforged.moddev.legacyforge.repositories.gradle.plugin")
includeModule("net.neoforged.moddev", "net.neoforged.moddev.gradle.plugin")
includeModule("net.neoforged.moddev.repositories", "net.neoforged.moddev.repositories.gradle.plugin")
includeModule("net.neoforged", "moddev-gradle")
}
}
} |
shartte
force-pushed
the
universal-jar
branch
from
83cbe16 to
9d3a358
Compare
neoforged-automation
bot
added
the
needs rebase
|
@Technici4n, this pull request has conflicts, please resolve them for this PR to move forward. |
# Conflicts: # src/main/java/net/neoforged/moddevgradle/internal/ModDevArtifactsWorkflow.java # src/main/java/net/neoforged/nfrtgradle/CreateMinecraftArtifacts.java
neoforged-automation
bot
removed
the
needs rebase
This comment has been minimized.
This comment has been minimized.
shartte
reviewed
Dec 18, 2025
Comment on lines
+126
to
+132
| // NFRT itself needs to run with a newer version of the JDK to be able to compile with -release 25, for example | ||
| // It can however not run with Java 25 and compile Java 8 code while maintaining the same lambda naming. | ||
| if (versionCapabilities.javaVersion() > 21) { | ||
| task.getJavaExecutable().set(javaToolchainService | ||
| .launcherFor(spec -> spec.getLanguageVersion().set(JavaLanguageVersion.of(versionCapabilities.javaVersion()))) | ||
| .map(javaLauncher -> javaLauncher.getExecutablePath().getAsFile().getAbsolutePath())); | ||
| } |
Collaborator
There was a problem hiding this comment.
While this works, it seems more future proof to run javac in NFRT with the external tool JRE
shartte
changed the title
|
🚀 This PR has been released as ModDevGradle version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: neoforged/NeoForge#2794neoforge-<version>-merged.jarsince it doesn't contain NeoForge anymore.