Skip to content

Commit 439359b

Browse files
authored
[hotfix] Renamed methods and variables. (#98)
* Renamed methods and variables. * Fixed invalid method call. * Fixed missed variable and method comment header.
1 parent c17a188 commit 439359b

File tree

28 files changed

+455
-446
lines changed

28 files changed

+455
-446
lines changed

Documentation/API/Parsers/ParseBpmFromChartSection.md renamed to Documentation/API/Parsers/ParseTempoChangesFromChartSection.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#### `Parsers.ParseBpmFromChartSection`
1+
#### `Parsers.ParseTempoChangesFromChartSection`
22

33
> Languages: `C#` `C++` `GDScript`
44
@@ -10,9 +10,9 @@ using RhythmGameUtilities;
1010

1111
var sections = Parsers.ParseSectionsFromChart(contents);
1212

13-
var bpm = Parsers.ParseBpmFromChartSection(sections[NamedSection.SyncTrack]);
13+
var tempoChanges = Parsers.ParseTempoChangesFromChartSection(sections[NamedSection.SyncTrack]);
1414

15-
Console.WriteLine(bpm.Length); // 7
15+
Console.WriteLine(tempoChanges.Length); // 7
1616
```
1717

1818
##### C++
@@ -31,10 +31,10 @@ int main()
3131

3232
auto sections = ParseSectionsFromChart(content.c_str());
3333

34-
auto bpm = ParseBpmFromChartSection(
34+
auto tempoChanges = ParseTempoChangesFromChartSection(
3535
sections.at(ToString(NamedSection::SyncTrack)));
3636

37-
std::cout << size(bpm) << std::endl; // 7
37+
std::cout << size(tempoChanges) << std::endl; // 7
3838

3939
return 0;
4040
}
@@ -51,7 +51,7 @@ func _ready() -> void:
5151
5252
var sections = rhythm_game_utilities.parse_sections_from_chart(content)
5353
54-
var bpm = rhythm_game_utilities.parse_bpm_from_chart_section(sections["SyncTrack"])
54+
var tempo_changes = rhythm_game_utilities.parse_tempo_changes_from_chart_section(sections["SyncTrack"])
5555
56-
print(bpm)
56+
print(tempo_changes)
5757
```

Documentation/API/Parsers/ParseTimeSignaturesFromChartSection.md renamed to Documentation/API/Parsers/ParseTimeSignaturesChangesFromChartSection.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#### `Parsers.ParseTimeSignaturesFromChartSection`
1+
#### `Parsers.ParseTimeSignatureChangesFromChartSection`
22

33
> Languages: `C#` `C++` `GDScript`
44
@@ -10,9 +10,9 @@ using RhythmGameUtilities;
1010

1111
var sections = Parsers.ParseSectionsFromChart(contents);
1212

13-
var timeSignatures = Parsers.ParseTimeSignaturesFromChartSection(sections[NamedSection.SyncTrack]);
13+
var timeSignatureChanges = Parsers.ParseTimeSignatureChangesFromChartSection(sections[NamedSection.SyncTrack]);
1414

15-
Console.WriteLine(timeSignatures.Length); // 4
15+
Console.WriteLine(timeSignatureChanges.Length); // 4
1616
```
1717

1818
##### C++
@@ -31,10 +31,10 @@ int main()
3131

3232
auto sections = ParseSectionsFromChart(content.c_str());
3333

34-
auto timeSignatures = ParseTimeSignaturesFromChartSection(
34+
auto timeSignatureChanges = ParseTimeSignatureChangesFromChartSection(
3535
sections.at(ToString(NamedSection::SyncTrack)));
3636

37-
std::cout << size(timeSignatures) << std::endl; // 4
37+
std::cout << size(timeSignatureChanges) << std::endl; // 4
3838

3939
return 0;
4040
}
@@ -51,7 +51,7 @@ func _ready() -> void:
5151
5252
var sections = rhythm_game_utilities.parse_sections_from_chart(content)
5353
54-
var time_signatures = rhythm_game_utilities.parse_time_signatures_from_chart_section(sections["SyncTrack"])
54+
var time_signature_changes = rhythm_game_utilities.parse_time_signature_changes_from_chart_section(sections["SyncTrack"])
5555
56-
print(time_signatures)
56+
print(time_signature_changes)
5757
```

Documentation/API/Utilities/CalculateAccuracyRatio.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@ const int seconds = 2;
1212
const int resolution = 192;
1313
const int positionDelta = 50;
1414

15-
var bpmChanges = new Tempo[] { new() { Position = 0, BPM = 120000 } };
15+
var tempoChanges = new Tempo[] { new() { Position = 0, BPM = 120000 } };
1616

1717
var timeSignatureChanges = new TimeSignature[] { new() { Position = 0, Numerator = 4, Denominator = 2 } };
1818

1919
var note = new Note { Position = 750 };
2020

2121
var currentPosition =
22-
Utilities.ConvertSecondsToTicks(seconds, resolution, bpmChanges, timeSignatureChanges);
22+
Utilities.ConvertSecondsToTicks(seconds, resolution, tempoChanges, timeSignatureChanges);
2323

2424
var value = Utilities.CalculateAccuracyRatio(note.Position, currentPosition, positionDelta);
2525

@@ -41,12 +41,12 @@ int main()
4141
const int resolution = 192;
4242
const int positionDelta = 50;
4343

44-
std::vector<Tempo> bpmChanges = {{0, 120000}};
44+
std::vector<Tempo> tempoChanges = {{0, 120000}};
4545
std::vector<TimeSignature> timeSignatureChanges = {{0, 4}};
4646

4747
auto note = new Note{750};
4848
auto currentPosition = ConvertSecondsToTicks(
49-
seconds, resolution, bpmChanges, timeSignatureChanges);
49+
seconds, resolution, tempoChanges, timeSignatureChanges);
5050

5151
auto value =
5252
CalculateAccuracyRatio(note->Position, currentPosition, positionDelta);
@@ -67,15 +67,15 @@ func _ready() -> void:
6767
var resolution = 192
6868
var position_delta = 50
6969
70-
var bpm_changes = [
70+
var tempo_changes = [
7171
{"position": 0, "bpm": 120000 }
7272
]
7373
7474
var time_signature_changes = [
7575
{"position": 0, "numerator": 4, "denominator": 2 }
7676
]
7777
78-
var current_position = rhythm_game_utilities.convert_seconds_to_ticks(seconds, resolution, bpm_changes, time_signature_changes)
78+
var current_position = rhythm_game_utilities.convert_seconds_to_ticks(seconds, resolution, tempo_changes, time_signature_changes)
7979
8080
var value = rhythm_game_utilities.calculate_accuracy_ratio(750, current_position, position_delta)
8181

Documentation/API/Utilities/CalculateBeatBars.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@
55
##### C#
66

77
```csharp
8-
var bpmChanges = new Tempo[]
8+
var tempoChanges = new Tempo[]
99
{
1010
new() { Position = 0, BPM = 88000 }, new() { Position = 3840, BPM = 112000 },
1111
new() { Position = 9984, BPM = 89600 }, new() { Position = 22272, BPM = 112000 },
1212
new() { Position = 33792, BPM = 111500 }, new() { Position = 34560, BPM = 112000 },
1313
new() { Position = 42240, BPM = 111980 }
1414
};
1515

16-
var beatBars = Utilities.CalculateBeatBars(bpmChanges);
16+
var beatBars = Utilities.CalculateBeatBars(tempoChanges);
1717

1818
Console.WriteLine(beatBars.Length); // 440
1919
```
@@ -32,12 +32,12 @@ int main()
3232
const int resolution = 192;
3333
const int timeSignature = 4;
3434

35-
std::vector<Tempo> bpmChanges = {
35+
std::vector<Tempo> tempoChanges = {
3636
{0, 88000}, {3840, 112000}, {9984, 89600}, {22272, 112000},
3737
{33792, 111500}, {34560, 112000}, {42240, 111980}};
3838

3939
auto beatBars =
40-
CalculateBeatBars(bpmChanges, resolution, timeSignature, true);
40+
CalculateBeatBars(tempoChanges, resolution, timeSignature, true);
4141

4242
std::cout << size(beatBars) << std::endl; // 440
4343

@@ -54,7 +54,7 @@ func _ready() -> void:
5454
var resolution = 192
5555
var time_signature = 4
5656
57-
var bpm_changes = [
57+
var tempo_changes = [
5858
{"position": 0, "bpm": 8800 },
5959
{"position": 3840, "bpm": 112000 },
6060
{"position": 9984, "bpm": 89600 },
@@ -64,7 +64,7 @@ func _ready() -> void:
6464
{"position": 42240, "bpm": 111980 }
6565
]
6666
67-
var beat_bars = rhythm_game_utilities.calculate_beat_bars(bpm_changes, resolution, time_signature, true)
67+
var beat_bars = rhythm_game_utilities.calculate_beat_bars(tempo_changes, resolution, time_signature, true)
6868
6969
print(beat_bars)
7070
```

Documentation/API/Utilities/ConvertSecondsToTicks.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ using RhythmGameUtilities;
1111
const int seconds = 5;
1212
const int resolution = 192;
1313

14-
var bpmChanges = new Tempo[]
14+
var tempoChanges = new Tempo[]
1515
{
1616
new() { Position = 0, BPM = 88000 }, new() { Position = 3840, BPM = 112000 },
1717
new() { Position = 9984, BPM = 89600 }, new() { Position = 22272, BPM = 112000 },
@@ -21,7 +21,7 @@ var bpmChanges = new Tempo[]
2121

2222
var timeSignatureChanges = new TimeSignature[] { new() { Position = 0, Numerator = 4, Denominator = 2 } };
2323

24-
var ticks = Utilities.ConvertSecondsToTicks(seconds, resolution, bpmChanges, timeSignatureChanges);
24+
var ticks = Utilities.ConvertSecondsToTicks(seconds, resolution, tempoChanges, timeSignatureChanges);
2525

2626
Console.WriteLine(ticks); // 1408
2727
```
@@ -40,13 +40,13 @@ int main()
4040
const int seconds = 5;
4141
const int resolution = 192;
4242

43-
std::vector<Tempo> bpmChanges = {
43+
std::vector<Tempo> tempoChanges = {
4444
{0, 88000}, {3840, 112000}, {9984, 89600}, {22272, 112000},
4545
{33792, 111500}, {34560, 112000}, {42240, 111980}};
4646

4747
std::vector<TimeSignature> timeSignatureChanges = {{0, 4, 2}};
4848

49-
auto ticks = ConvertSecondsToTicks(seconds, resolution, bpmChanges,
49+
auto ticks = ConvertSecondsToTicks(seconds, resolution, tempoChanges,
5050
timeSignatureChanges);
5151

5252
std::cout << ticks << std::endl; // 1408
@@ -64,7 +64,7 @@ func _ready() -> void:
6464
var seconds = 5
6565
var resolution = 192
6666
67-
var bpm_changes = [
67+
var tempo_changes = [
6868
{"position": 0, "bpm": 88000 },
6969
{"position": 3840, "bpm": 112000 },
7070
{"position": 9984, "bpm": 89600 },
@@ -78,7 +78,7 @@ func _ready() -> void:
7878
{"position": 0, "numerator": 4, "denominator": 2 }
7979
]
8080
81-
var current_position = rhythm_game_utilities.convert_seconds_to_ticks(seconds, resolution, bpm_changes, time_signature_changes)
81+
var current_position = rhythm_game_utilities.convert_seconds_to_ticks(seconds, resolution, tempo_changes, time_signature_changes)
8282
8383
print(current_position) # 1408
8484
```

Documentation/Architecture.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@ graph LR;
1919
2020
subgraph parsersGraph ["Parsers"]
2121
parseSectionsFromChart["ParseSectionsFromChart()"]
22-
parseBpmFromChartSection["ParseBpmFromChartSection()"]
22+
parseBpmFromChartSection["ParseTempoChangesFromChartSection()"]
2323
parseLyricsFromChartSection["ParseLyricsFromChartSection()"]
2424
parseMetaDataFromChartSection["ParseMetaDataFromChartSection()"]
2525
parseNotesFromChartSection["ParseNotesFromChartSection()"]
26-
parseTimeSignaturesFromChartSection["ParseTimeSignaturesFromChartSection()"]
26+
parseTimeSignaturesFromChartSection["ParseTimeSignatureChangesFromChartSection()"]
2727
2828
parseSectionsFromChart-->parseBpmFromChartSection
2929
parseSectionsFromChart-->parseLyricsFromChartSection

Documentation/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,12 @@ _Prototype game built using these utilities._
4040
1. [InverseLerp](#commoninverselerp)
4141
1. [Lerp](#commonlerp)
4242
1. [Parsers](#parsers)
43-
1. [ParseBpmFromChartSection](#parsersparsebpmfromchartsection)
43+
1. [ParseTempoChangesFromChartSection](#parsersparsetempochangesfromchartsection)
4444
1. [ParseLyricsFromChartSection](#parsersparselyricsfromchartsection)
4545
1. [ParseMetaDataFromChartSection](#parsersparsemetadatafromchartsection)
4646
1. [ParseNotesFromChartSection](#parsersparsenotesfromchartsection)
4747
1. [ParseSectionsFromChart](#parsersparsesectionsfromchart)
48-
1. [ParseTimeSignaturesFromChartSection](#parsersparsetimesignaturesfromchartsection)
48+
1. [ParseTimeSignatureChangesFromChartSection](#parsersparsetimesignaturechangesfromchartsection)
4949
1. [Utilities](#utilities)
5050
1. [CalculateAccuracyRatio](#utilitiescalculateaccuracyratio)
5151
1. [CalculateBeatBars](#utilitiescalculatebeatbars)

0 commit comments

Comments
 (0)