Skip to content

Commit a2b55c6

Browse files
authored
Merge pull request #48 from neogeek/hotfix/name-collision
[hotfix] Renamed TypeCodes to avoid name collisions with structs.
2 parents 919f261 + 93dc8fb commit a2b55c6

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

includes/RhythmGameUtilities/Enums/TypeCode.h

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,30 +9,30 @@ typedef enum TypeCode
99
{
1010

1111
/// BPM Marker
12-
BPM,
12+
BPM_Marker,
1313

1414
/// Time Signature Marker
15-
TimeSignature,
15+
TimeSignatureMarker,
1616

1717
/// Note Marker
18-
Note,
18+
NoteMarker,
1919

2020
/// Event Marker
21-
Event
21+
EventMarker
2222

2323
} TypeCodeType;
2424

2525
std::string ToString(TypeCode typeCode)
2626
{
2727
switch (typeCode)
2828
{
29-
case BPM:
29+
case BPM_Marker:
3030
return "B";
31-
case TimeSignature:
31+
case TimeSignatureMarker:
3232
return "TS";
33-
case Note:
33+
case NoteMarker:
3434
return "N";
35-
case Event:
35+
case EventMarker:
3636
return "E";
3737
}
3838
}

tests/RhythmGameUtilities/Enum.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ void testNamedSection()
2828

2929
void testTypeCode()
3030
{
31-
assert(ToString(TypeCode::BPM) == "B");
32-
assert(ToString(TypeCode::TimeSignature) == "TS");
33-
assert(ToString(TypeCode::Note) == "N");
34-
assert(ToString(TypeCode::Event) == "E");
31+
assert(ToString(TypeCode::BPM_Marker) == "B");
32+
assert(ToString(TypeCode::TimeSignatureMarker) == "TS");
33+
assert(ToString(TypeCode::NoteMarker) == "N");
34+
assert(ToString(TypeCode::EventMarker) == "E");
3535

3636
std::cout << ".";
3737
}

0 commit comments

Comments
 (0)