Skip to content

[BUG] Improving/changing the spell checker leads to tests breaking, implementation changing #79

@neomatrix369

Description

@neomatrix369

Describe the bug

On the back of the PR #71 which was reverted from master due to breaking changes, would be best to review, and fix either implement/tests or both and merge to master.

To Reproduce

Clone the branch related to PR #71 and run all the tests.

Version information:

Version 0.0.3 - no other aspects are linked to it

Additional context

The steps would be following in order to apply and test the improvements to the spell checker:

  • get latest changes on local master
  • branch from master for spell checker changes
  • run all the tests with ./test-coverage.sh tests slow-tests
  • apply the spell checker changes as applied previously via PR Spelling checker has been modified #71
  • run all the tests with ./test-coverage.sh tests slow-tests
  • fix tests such that the tests are passing for the right reasons
  • create Pull Request and follow guidelines (GA on PR should indicate if the changes are good or not)

PR #71 was reverted via PR #75.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions