-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Description
(This issue has been an internal draft since Apr 30 for no good readon)
tokio-epoll-uring
currently has to do some unsafe impl Send + Sync
:
unsafe impl Send for CompletionSide {} |
tokio-epoll-uring/tokio-epoll-uring/src/system/lifecycle.rs
Lines 60 to 64 in d6a1c93
// SAFETY: we never use the raw IoUring pointer and it's not thread-local or anything like that. | |
unsafe impl Send for System {} | |
// SAFETY: we never use the raw IoUring pointer and it's not thread-local or anything like that. | |
unsafe impl Sync for System {} |
tokio-epoll-uring/tokio-epoll-uring/src/system/submission.rs
Lines 171 to 173 in 91d67e2
unsafe impl Send for SubmitSideOpen {} | |
unsafe impl Sync for SubmitSideOpen {} |
These are necessary because the underlying io_uring
crate's Submitter
, SubmissionQueue
, and CompletionQueue
struct are not impl Send + Sync
, even though they could be.
- => create upstream PR to make our case & add the unsafe impl: unsafe impl
Send+Sync
forSubmitter
,SubmissionQueue
,CompletionQueue
tokio-rs/io-uring#283
Week starting May 6: pause one week, solicit feedback on Discord next week.
2024-05-28: reached out on Discord
Metadata
Metadata
Assignees
Labels
No labels