Skip to content

avoid our unsafe impl Send + Sync by pushing it upstream #53

@problame

Description

@problame

(This issue has been an internal draft since Apr 30 for no good readon)


tokio-epoll-uring currently has to do some unsafe impl Send + Sync:

unsafe impl Send for CompletionSide {}

// SAFETY: we never use the raw IoUring pointer and it's not thread-local or anything like that.
unsafe impl Send for System {}
// SAFETY: we never use the raw IoUring pointer and it's not thread-local or anything like that.
unsafe impl Sync for System {}

unsafe impl Send for SubmitSideOpen {}
unsafe impl Sync for SubmitSideOpen {}

These are necessary because the underlying io_uring crate's Submitter, SubmissionQueue, and CompletionQueue struct are not impl Send + Sync, even though they could be.



Week starting May 6: pause one week, solicit feedback on Discord next week.

2024-05-28: reached out on Discord

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions