TASK: Adjust phpstan config to apply level 8 rules to the Flow/Session context and reduce breakiness

Author: mficzel

Neos.Flow/Classes/Session/Session.php

@@ -300,12 +300,12 @@ public function renewId(): string
         if (!$this->sessionMetaData) {
             throw new \Exception('Missing session metadata');
         }
-        if (!$this->sessionCookie) {
-            throw new \Exception('Missing session cookie');
-        }
         if ($this->remote === true) {
             throw new Exception\OperationNotSupportedException(sprintf('Tried to renew the session identifier on a remote session (%s).', $this->sessionMetaData->sessionIdentifier->value), 1354034230);
         }
+        if (!$this->sessionCookie) {
+            throw new \Exception('Missing session cookie');
+        }
 
         $this->sessionMetaDataStore->remove($this->sessionMetaData);
         $this->sessionMetaData = $this->sessionMetaData->withNewSessionIdentifier();

phpstan.neon.dist

@@ -1,6 +1,7 @@
 parameters:
     level: 8
     paths:
+        - Neos.Flow/Classes/Session
         - Neos.Flow/Classes/SignalSlot
         - Neos.Flow/Classes/Utility
         - Neos.Flow/Classes/Validation