TASK: Raise PhpStan level for Flow.Log to 8 and adjust breakiness

mficzel · mficzel · commit 5e02f0c50288 · 2025-10-27T16:06:04.000+01:00
diff --git a/Neos.Flow.Log/Classes/PlainTextFormatter.php b/Neos.Flow.Log/Classes/PlainTextFormatter.php
@@ -22,9 +22,10 @@ public function __construct($variable)
     }
 
     /**
+     * @param int $spaces
      * @return ?string
      */
-    public function format(int $spaces = 4)
+    public function format($spaces = 4)
     {
         return $this->renderVariableAsPlaintext($this->variable, $spaces);
     }
diff --git a/phpstan-legacy.neon.dist b/phpstan-legacy.neon.dist
@@ -5,7 +5,6 @@ parameters:
         - Neos.Eel/Classes
         - Neos.Error.Messages/Classes
         - Neos.Flow/Classes
-        - Neos.Flow.Log/Classes
     bootstrapFiles:
          - bootstrap-phpstan.php
     excludePaths:
diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -1,6 +1,7 @@
 parameters:
     level: 8
     paths:
+        - Neos.Flow.Log/Classes
         - Neos.FluidAdaptor/Classes
         - Neos.Http.Factories/Classes
         - Neos.Kickstarter/Classes

Original file line number	Diff line number	Diff line change
`@@ -22,9 +22,10 @@ public function __construct($variable)`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`/**`
	`25`	`+ * @param int $spaces`
`25`	`26`	`* @return ?string`
`26`	`27`	`*/`
`27`		`- public function format(int $spaces = 4)`
	`28`	`+ public function format($spaces = 4)`
`28`	`29`	`{`
`29`	`30`	`return $this->renderVariableAsPlaintext($this->variable, $spaces);`
`30`	`31`	`}`