Add functional test for proxy serialization bug

Author: robertlemke

Neos.Flow/Tests/Functional/ObjectManagement/Fixtures/ClassWithEntityProperty.php

@@ -0,0 +1,40 @@
+<?php
+namespace Neos\Flow\Tests\Functional\ObjectManagement\Fixtures;
+
+/*
+ * This file is part of the Neos.Flow package.
+ *
+ * (c) Contributors of the Neos Project - www.neos.io
+ *
+ * This package is Open Source Software. For the full copyright and license
+ * information, please view the LICENSE file which was distributed with this
+ * source code.
+ */
+
+use Neos\Flow\Annotations as Flow;
+
+/**
+ * A prototype class with an entity property (Issue #3493)
+ * Before the fix, this class would NOT get serialization code
+ * because the proxy builder was too eager in skipping it.
+ *
+ * @Flow\Scope("prototype")
+ */
+class ClassWithEntityProperty
+{
+    /**
+     * @var SimpleEntity
+     */
+    public $entity;
+
+    /**
+     * @var string
+     */
+    public $someValue;
+
+    public function __construct(SimpleEntity $entity, string $someValue = 'default')
+    {
+        $this->entity = $entity;
+        $this->someValue = $someValue;
+    }
+}

Neos.Flow/Tests/Functional/ObjectManagement/Fixtures/SimpleEntity.php

@@ -0,0 +1,37 @@
+<?php
+namespace Neos\Flow\Tests\Functional\ObjectManagement\Fixtures;
+
+/*
+ * This file is part of the Neos.Flow package.
+ *
+ * (c) Contributors of the Neos Project - www.neos.io
+ *
+ * This package is Open Source Software. For the full copyright and license
+ * information, please view the LICENSE file which was distributed with this
+ * source code.
+ */
+
+use Neos\Flow\Annotations as Flow;
+
+/**
+ * A simple entity for testing proxy serialization
+ *
+ * @Flow\Entity
+ */
+class SimpleEntity
+{
+    /**
+     * @var string
+     */
+    protected $name = '';
+
+    public function __construct(string $name = '')
+    {
+        $this->name = $name;
+    }
+
+    public function getName(): string
+    {
+        return $this->name;
+    }
+}

Neos.Flow/Tests/Functional/ObjectManagement/ProxySerializationTest.php

@@ -0,0 +1,39 @@
+<?php
+namespace Neos\Flow\Tests\Functional\ObjectManagement;
+
+/*
+ * This file is part of the Neos.Flow package.
+ *
+ * (c) Contributors of the Neos Project - www.neos.io
+ *
+ * This package is Open Source Software. For the full copyright and license
+ * information, please view the LICENSE file which was distributed with this
+ * source code.
+ */
+
+use Neos\Flow\Tests\FunctionalTestCase;
+
+/**
+ * Test for Issue #3493: Classes with entity properties should get serialization code
+ */
+class ProxySerializationTest extends FunctionalTestCase
+{
+    protected static $testablePersistenceEnabled = true;
+
+    /**
+     * @test
+     */
+    public function classWithEntityPropertyCanBeSerialized(): void
+    {
+        $entity = new Fixtures\SimpleEntity('Test Entity');
+        $object = new Fixtures\ClassWithEntityProperty($entity, 'some value');
+
+        // This should not fail - the proxy should have __sleep() method
+        // Before the fix, this would fail because entity references would not be stripped
+        $serialized = serialize($object);
+        $unserialized = unserialize($serialized);
+
+        self::assertInstanceOf(Fixtures\ClassWithEntityProperty::class, $unserialized);
+        self::assertEquals('some value', $unserialized->someValue);
+    }
+}