TASK: Fix Review issues

Author: JamesAlias

Classes/Aspects/AugmentationAspect.php

@@ -152,7 +152,6 @@ public function editableElementAugmentation(JoinPointInterface $joinPoint)
             return $content;
         }
 
-        // TODO: this is where we could use a feature flag
         if ($this->nodePolicyService->canReadNode($node) === false) {
             return $content;
         }

Classes/Service/NodePolicyService.php

@@ -82,7 +82,7 @@ public function getNodePolicyInformation(NodeInterface $node): array
             'disallowedNodeTypes' => $this->getDisallowedNodeTypes($node),
             'canRemove' => $this->canRemoveNode($node),
             'canEdit' => $this->canEditNode($node),
-            'canView' => $this->canReadNode($node),
+            'canRead' => $this->canReadNode($node),
             'disallowedProperties' => $this->getDisallowedProperties($node)
         ];
     }

packages/neos-ui-guest-frame/src/initializeGuestFrame.js

@@ -115,7 +115,6 @@ export default ({globalRegistry, store}) => function * initializeGuestFrame() {
     const currentEditMode = editPreviewModes[editPreviewMode];
 
     // ReadOnly workspaces are handled by ckEditor directly
-    // TODO: this will break other editors, correct?
     if (!currentEditMode || !currentEditMode.isEditingMode) {
         return;
     }

packages/neos-ui-guest-frame/src/initializePropertyDomNode.js

@@ -1,11 +1,9 @@
 import {$get, $contains} from 'plow-js';
 
-import {actions} from '@neos-project/neos-ui-redux-store';
+import {actions, selectors} from '@neos-project/neos-ui-redux-store';
 import {validateElement} from '@neos-project/neos-ui-validators';
 
 import {getGuestFrameWindow, closestContextPathInGuestFrame} from './dom';
-// TODO: this import feels foreign to the rest of neos code, but it feels strange to import the complete selectors object
-import {isWorkspaceReadOnlySelector} from '@neos-project/neos-ui-redux-store/src/CR/Workspaces/selectors';
 
 export default ({store, globalRegistry, nodeTypesRegistry, inlineEditorRegistry, nodes}) => propertyDomNode => {
     const guestFrameWindow = getGuestFrameWindow();
@@ -63,7 +61,7 @@ export default ({store, globalRegistry, nodeTypesRegistry, inlineEditorRegistry,
         try {
             if (!propertyDomNode.dataset.neosInlineEditorIsInitialized) {
                 const userPreferences = $get('user.preferences', store.getState());
-                const isReadOnly = isWorkspaceReadOnlySelector(store.getState());
+                const isWorkspaceReadOnly = selectors.CR.Workspaces.isWorkspaceReadOnlySelector(store.getState());
 
                 createInlineEditor({
                     propertyDomNode,
@@ -73,9 +71,9 @@ export default ({store, globalRegistry, nodeTypesRegistry, inlineEditorRegistry,
                     editorOptions,
                     globalRegistry,
                     userPreferences,
-                    isReadOnly,
+                    isReadOnly: isWorkspaceReadOnly,
                     persistChange: change => {
-                        if (isReadOnly) {
+                        if (isWorkspaceReadOnly) {
                             return;
                         }
 
@@ -84,7 +82,7 @@ export default ({store, globalRegistry, nodeTypesRegistry, inlineEditorRegistry,
                         )
                     },
                     onChange: value => {
-                        if (isReadOnly) {
+                        if (isWorkspaceReadOnly) {
                             return;
                         }
 

packages/neos-ui/src/Containers/RightSideBar/Inspector/TabPanel/index.js

@@ -30,7 +30,7 @@ export default class TabPanel extends PureComponent {
             return false;
         }
 
-        return $get(['policy', 'canView'], node) && !$contains(item.id, 'policy.disallowedProperties', node);
+        return $get(['policy', 'canRead'], node) && !$contains(item.id, 'policy.disallowedProperties', node);
     };
 
     renderTabPanel = groups => {

packages/neos-ui/src/Containers/RightSideBar/Inspector/index.js

@@ -247,7 +247,7 @@ export default class Inspector extends PureComponent {
             return false;
         }
 
-        return $get(['policy', 'canView'], focusedNode) && !$contains(item.id, 'policy.disallowedProperties', focusedNode);
+        return $get(['policy', 'canRead'], focusedNode) && !$contains(item.id, 'policy.disallowedProperties', focusedNode);
     };
 
     /**