Fix exception calling memcpy with null pointer

mqudsi · mqudsi · commit 794a4400f51a · 2025-06-02T15:33:36.000-05:00
In the event of mnBufferLen == 0, mpBuf could be null.
diff --git a/src/CppSQLite3.cpp b/src/CppSQLite3.cpp
@@ -57,7 +57,9 @@ SQLite3Memory::SQLite3Memory(SQLite3Memory const &other)
         throw CppSQLite3Exception(CPPSQLITE_ERROR, ALLOCATION_ERROR_MESSAGE,
                                   DONT_DELETE_MSG);
     }
-    std::memcpy(mpBuf, other.mpBuf, mnBufferLen);
+    if (mnBufferLen > 0) {
+        std::memcpy(mpBuf, other.mpBuf, mnBufferLen);
+    }
 }
 
 SQLite3Memory &SQLite3Memory::operator=(SQLite3Memory const &lhs) {

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,9 @@ SQLite3Memory::SQLite3Memory(SQLite3Memory const &other)`
`57`	`57`	`throw CppSQLite3Exception(CPPSQLITE_ERROR, ALLOCATION_ERROR_MESSAGE,`
`58`	`58`	`DONT_DELETE_MSG);`
`59`	`59`	`}`
`60`		`- std::memcpy(mpBuf, other.mpBuf, mnBufferLen);`
	`60`	`+ if (mnBufferLen > 0) {`
	`61`	`+ std::memcpy(mpBuf, other.mpBuf, mnBufferLen);`
	`62`	`+ }`
`61`	`63`	`}`
`62`	`64`
`63`	`65`	`SQLite3Memory &SQLite3Memory::operator=(SQLite3Memory const &lhs) {`