Skip to content

Fix the 3 missing UnitTests ColorConversion - brightness #16

@Chris53897

Description

@Chris53897

There are actual 3 UnitTests that are failing.
https://github.com/neoteknic/Phue/runs/8056721561?check_suite_focus=true

These are all linked to the new option $bri (brightness)
https://github.com/neoteknic/Phue/blob/master/library/Phue/Helper/ColorConversion.php#L74

@neoteknic Can you please fix these as i do not know what the expected output is with the new variable?
But with the default value (null?) the result should have the same result as the original PhpUnit tests.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions