Skip to content

Commit 96d7cca

Browse files
committed
fix(nvim): expect commands based on nvim version
for nvim minor verion 9, no commands are returned for nvim minor version 10, three are returned currently, for nightly builds, four are returend
1 parent f45ea35 commit 96d7cca

File tree

2 files changed

+28
-10
lines changed

2 files changed

+28
-10
lines changed

.github/workflows/test.yml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ on:
44
push:
55
branches:
66
- main
7-
# TODO: don't add this in the pr
8-
- fix-tests
97
pull_request:
108
release:
119
types:
@@ -23,11 +21,11 @@ jobs:
2321
matrix:
2422
os:
2523
- ubuntu-22.04 # https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md
26-
# - macos-13 # https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md
27-
# - windows-2022 # https://github.com/actions/runner-images/blob/main/images/win/Windows2022-Readme.md
24+
- macos-13 # https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md
25+
- windows-2022 # https://github.com/actions/runner-images/blob/main/images/win/Windows2022-Readme.md
2826
go-version:
29-
# - 1.18.x
30-
# - 1.19.x
27+
- 1.18.x
28+
- 1.19.x
3129
- 1.20.x
3230
neovim-version:
3331
- v0.9.1

nvim/api_test.go

Lines changed: 24 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2250,8 +2250,19 @@ func testCommand(v *Nvim) func(*testing.T) {
22502250
if err != nil {
22512251
t.Fatal(err)
22522252
}
2253-
if len(cmds) > 0 {
2254-
t.Fatalf("expected 0 length but got %#v", cmds)
2253+
2254+
var want int
2255+
switch nvimVersion.Minor {
2256+
case 9:
2257+
want = 0
2258+
case 10:
2259+
want = 3
2260+
default:
2261+
want = 4
2262+
}
2263+
2264+
if len(cmds) > want {
2265+
t.Fatalf("expected %d length but got %#v", want, cmds)
22552266
}
22562267
})
22572268

@@ -2266,8 +2277,17 @@ func testCommand(v *Nvim) func(*testing.T) {
22662277
if err := b.Execute(); err != nil {
22672278
t.Fatal(err)
22682279
}
2269-
if len(cmds) > 0 {
2270-
t.Fatalf("expected 0 length but got %#v", cmds)
2280+
var want int
2281+
switch nvimVersion.Minor {
2282+
case 9:
2283+
want = 0
2284+
case 10:
2285+
want = 3
2286+
default:
2287+
want = 4
2288+
}
2289+
if len(cmds) > want {
2290+
t.Fatalf("expected %d length but got %#v", want, cmds)
22712291
}
22722292
})
22732293
})

0 commit comments

Comments
 (0)