|
51 | 51 | "url": "https://api.github.com/users/echasnovski", |
52 | 52 | "user_view_type": "public" |
53 | 53 | } |
| 54 | + }, |
| 55 | + { |
| 56 | + "author_association": "MEMBER", |
| 57 | + "body": "> The codeblock highlighting on the site does not match the site theme. In particular it has purple which is nowhere else in the site theme.\n\nI've just had a thought to suggest a darker background for code blocks, but with the same hue. But after looking at colors, it already is:\n- Basic background is `#0f191f`, which is [lightness 11, chroma 2, hue 235](https://bottosson.github.io/misc/colorpicker/#0f191f).\n- Codeblock background is `#0b151b`, which is [lightness 9, same chroma (2) and hue (235)](https://bottosson.github.io/misc/colorpicker/#0b151b).\n\nSo although they might not look like coordinated, they are. Maybe going even more dark will be an improvement? Here is what `#040d12` (lightness 6, chroma 2, hue 235) looks like as code background:\n\n<img width=\"2153\" height=\"1608\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/1578bf8d-e43e-4b14-b0cd-61d97ed4fceb\" />\n\nThis makes code blocks stand out more and (as a bonus) improves contrast ratio in them.", |
| 58 | + "created_at": "2025-10-07T11:52:09Z", |
| 59 | + "html_url": "https://github.com/neovim/neovim.github.io/issues/388#issuecomment-3376542840", |
| 60 | + "id": 3376542840, |
| 61 | + "issue_url": "https://api.github.com/repos/neovim/neovim.github.io/issues/388", |
| 62 | + "node_id": "IC_kwDOAQSZx87JQfR4", |
| 63 | + "performed_via_github_app": null, |
| 64 | + "reactions": { |
| 65 | + "+1": 0, |
| 66 | + "-1": 0, |
| 67 | + "confused": 0, |
| 68 | + "eyes": 0, |
| 69 | + "heart": 0, |
| 70 | + "hooray": 0, |
| 71 | + "laugh": 0, |
| 72 | + "rocket": 0, |
| 73 | + "total_count": 0, |
| 74 | + "url": "https://api.github.com/repos/neovim/neovim.github.io/issues/comments/3376542840/reactions" |
| 75 | + }, |
| 76 | + "updated_at": "2025-10-07T11:52:09Z", |
| 77 | + "url": "https://api.github.com/repos/neovim/neovim.github.io/issues/comments/3376542840", |
| 78 | + "user": { |
| 79 | + "avatar_url": "https://avatars.githubusercontent.com/u/24854248?v=4", |
| 80 | + "events_url": "https://api.github.com/users/echasnovski/events{/privacy}", |
| 81 | + "followers_url": "https://api.github.com/users/echasnovski/followers", |
| 82 | + "following_url": "https://api.github.com/users/echasnovski/following{/other_user}", |
| 83 | + "gists_url": "https://api.github.com/users/echasnovski/gists{/gist_id}", |
| 84 | + "gravatar_id": "", |
| 85 | + "html_url": "https://github.com/echasnovski", |
| 86 | + "id": 24854248, |
| 87 | + "login": "echasnovski", |
| 88 | + "node_id": "MDQ6VXNlcjI0ODU0MjQ4", |
| 89 | + "organizations_url": "https://api.github.com/users/echasnovski/orgs", |
| 90 | + "received_events_url": "https://api.github.com/users/echasnovski/received_events", |
| 91 | + "repos_url": "https://api.github.com/users/echasnovski/repos", |
| 92 | + "site_admin": false, |
| 93 | + "starred_url": "https://api.github.com/users/echasnovski/starred{/owner}{/repo}", |
| 94 | + "subscriptions_url": "https://api.github.com/users/echasnovski/subscriptions", |
| 95 | + "type": "User", |
| 96 | + "url": "https://api.github.com/users/echasnovski", |
| 97 | + "user_view_type": "public" |
| 98 | + } |
| 99 | + }, |
| 100 | + { |
| 101 | + "author_association": "MEMBER", |
| 102 | + "body": "The main goal here is to not use purple, the syntax should align with the site theme. Your screenshots still have purple.", |
| 103 | + "created_at": "2025-10-07T19:42:37Z", |
| 104 | + "html_url": "https://github.com/neovim/neovim.github.io/issues/388#issuecomment-3378464311", |
| 105 | + "id": 3378464311, |
| 106 | + "issue_url": "https://api.github.com/repos/neovim/neovim.github.io/issues/388", |
| 107 | + "node_id": "IC_kwDOAQSZx87JX0Y3", |
| 108 | + "performed_via_github_app": null, |
| 109 | + "reactions": { |
| 110 | + "+1": 0, |
| 111 | + "-1": 0, |
| 112 | + "confused": 0, |
| 113 | + "eyes": 0, |
| 114 | + "heart": 0, |
| 115 | + "hooray": 0, |
| 116 | + "laugh": 0, |
| 117 | + "rocket": 0, |
| 118 | + "total_count": 0, |
| 119 | + "url": "https://api.github.com/repos/neovim/neovim.github.io/issues/comments/3378464311/reactions" |
| 120 | + }, |
| 121 | + "updated_at": "2025-10-07T19:42:52Z", |
| 122 | + "url": "https://api.github.com/repos/neovim/neovim.github.io/issues/comments/3378464311", |
| 123 | + "user": { |
| 124 | + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", |
| 125 | + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", |
| 126 | + "followers_url": "https://api.github.com/users/justinmk/followers", |
| 127 | + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", |
| 128 | + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", |
| 129 | + "gravatar_id": "", |
| 130 | + "html_url": "https://github.com/justinmk", |
| 131 | + "id": 1359421, |
| 132 | + "login": "justinmk", |
| 133 | + "node_id": "MDQ6VXNlcjEzNTk0MjE=", |
| 134 | + "organizations_url": "https://api.github.com/users/justinmk/orgs", |
| 135 | + "received_events_url": "https://api.github.com/users/justinmk/received_events", |
| 136 | + "repos_url": "https://api.github.com/users/justinmk/repos", |
| 137 | + "site_admin": false, |
| 138 | + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", |
| 139 | + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", |
| 140 | + "type": "User", |
| 141 | + "url": "https://api.github.com/users/justinmk", |
| 142 | + "user_view_type": "public" |
| 143 | + } |
| 144 | + }, |
| 145 | + { |
| 146 | + "author_association": "MEMBER", |
| 147 | + "body": "> The main goal here is to not use purple, the syntax should align with the site theme. Your screenshots still have purple.\n\nAh, you mean foreground in syntax highlighting... 🤦 I thought you meant background of codeblocks.\n\nYeah, I agree. Not huge issue for me, but might be not very well aligned.\n\nAs far as I can tell from the place of the screenshot, the color is `#c0caf5`. Which means that it comes from [here](https://github.com/neovim/neovim.github.io/blob/a8f484941f3212b3a370fc8a3aab613c25109a46/css/neovim-hi.css#L44). And [this](https://github.com/neovim/neovim.github.io/blob/a8f484941f3212b3a370fc8a3aab613c25109a46/css/neovim-hi.css#L49) is the only place that uses it.\n\nIf `--hi-b-white` is replaced with site's default foreground (`#a9d5c4`), here is how it looks:\n\n<img width=\"2135\" height=\"1600\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/93e75ef9-a402-49a7-8ce2-0258001a1349\" />\n\nThe comments are darker purple also. If `--hi-white` is also replaced with link's color (`#5fb950`), here is how it looks:\n\n<img width=\"2377\" height=\"1343\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/d89c036c-fb7c-4809-9f72-98c023643ea8\" />\n\nMaybe a bit too much green, but no purple at least :)\n\n---\n\nFor reference, the theme came in #303 and #304", |
| 148 | + "created_at": "2025-10-07T20:02:28Z", |
| 149 | + "html_url": "https://github.com/neovim/neovim.github.io/issues/388#issuecomment-3378523271", |
| 150 | + "id": 3378523271, |
| 151 | + "issue_url": "https://api.github.com/repos/neovim/neovim.github.io/issues/388", |
| 152 | + "node_id": "IC_kwDOAQSZx87JYCyH", |
| 153 | + "performed_via_github_app": null, |
| 154 | + "reactions": { |
| 155 | + "+1": 0, |
| 156 | + "-1": 0, |
| 157 | + "confused": 0, |
| 158 | + "eyes": 0, |
| 159 | + "heart": 1, |
| 160 | + "hooray": 0, |
| 161 | + "laugh": 0, |
| 162 | + "rocket": 0, |
| 163 | + "total_count": 1, |
| 164 | + "url": "https://api.github.com/repos/neovim/neovim.github.io/issues/comments/3378523271/reactions" |
| 165 | + }, |
| 166 | + "updated_at": "2025-10-07T20:02:28Z", |
| 167 | + "url": "https://api.github.com/repos/neovim/neovim.github.io/issues/comments/3378523271", |
| 168 | + "user": { |
| 169 | + "avatar_url": "https://avatars.githubusercontent.com/u/24854248?v=4", |
| 170 | + "events_url": "https://api.github.com/users/echasnovski/events{/privacy}", |
| 171 | + "followers_url": "https://api.github.com/users/echasnovski/followers", |
| 172 | + "following_url": "https://api.github.com/users/echasnovski/following{/other_user}", |
| 173 | + "gists_url": "https://api.github.com/users/echasnovski/gists{/gist_id}", |
| 174 | + "gravatar_id": "", |
| 175 | + "html_url": "https://github.com/echasnovski", |
| 176 | + "id": 24854248, |
| 177 | + "login": "echasnovski", |
| 178 | + "node_id": "MDQ6VXNlcjI0ODU0MjQ4", |
| 179 | + "organizations_url": "https://api.github.com/users/echasnovski/orgs", |
| 180 | + "received_events_url": "https://api.github.com/users/echasnovski/received_events", |
| 181 | + "repos_url": "https://api.github.com/users/echasnovski/repos", |
| 182 | + "site_admin": false, |
| 183 | + "starred_url": "https://api.github.com/users/echasnovski/starred{/owner}{/repo}", |
| 184 | + "subscriptions_url": "https://api.github.com/users/echasnovski/subscriptions", |
| 185 | + "type": "User", |
| 186 | + "url": "https://api.github.com/users/echasnovski", |
| 187 | + "user_view_type": "public" |
| 188 | + } |
| 189 | + }, |
| 190 | + { |
| 191 | + "author_association": "MEMBER", |
| 192 | + "body": "But if redesign is in order, then using Neovim's own default color scheme for the whole site might be the way to go 🤔 ", |
| 193 | + "created_at": "2025-10-07T20:12:47Z", |
| 194 | + "html_url": "https://github.com/neovim/neovim.github.io/issues/388#issuecomment-3378554012", |
| 195 | + "id": 3378554012, |
| 196 | + "issue_url": "https://api.github.com/repos/neovim/neovim.github.io/issues/388", |
| 197 | + "node_id": "IC_kwDOAQSZx87JYKSc", |
| 198 | + "performed_via_github_app": null, |
| 199 | + "reactions": { |
| 200 | + "+1": 0, |
| 201 | + "-1": 0, |
| 202 | + "confused": 0, |
| 203 | + "eyes": 0, |
| 204 | + "heart": 0, |
| 205 | + "hooray": 0, |
| 206 | + "laugh": 0, |
| 207 | + "rocket": 0, |
| 208 | + "total_count": 0, |
| 209 | + "url": "https://api.github.com/repos/neovim/neovim.github.io/issues/comments/3378554012/reactions" |
| 210 | + }, |
| 211 | + "updated_at": "2025-10-07T20:12:47Z", |
| 212 | + "url": "https://api.github.com/repos/neovim/neovim.github.io/issues/comments/3378554012", |
| 213 | + "user": { |
| 214 | + "avatar_url": "https://avatars.githubusercontent.com/u/24854248?v=4", |
| 215 | + "events_url": "https://api.github.com/users/echasnovski/events{/privacy}", |
| 216 | + "followers_url": "https://api.github.com/users/echasnovski/followers", |
| 217 | + "following_url": "https://api.github.com/users/echasnovski/following{/other_user}", |
| 218 | + "gists_url": "https://api.github.com/users/echasnovski/gists{/gist_id}", |
| 219 | + "gravatar_id": "", |
| 220 | + "html_url": "https://github.com/echasnovski", |
| 221 | + "id": 24854248, |
| 222 | + "login": "echasnovski", |
| 223 | + "node_id": "MDQ6VXNlcjI0ODU0MjQ4", |
| 224 | + "organizations_url": "https://api.github.com/users/echasnovski/orgs", |
| 225 | + "received_events_url": "https://api.github.com/users/echasnovski/received_events", |
| 226 | + "repos_url": "https://api.github.com/users/echasnovski/repos", |
| 227 | + "site_admin": false, |
| 228 | + "starred_url": "https://api.github.com/users/echasnovski/starred{/owner}{/repo}", |
| 229 | + "subscriptions_url": "https://api.github.com/users/echasnovski/subscriptions", |
| 230 | + "type": "User", |
| 231 | + "url": "https://api.github.com/users/echasnovski", |
| 232 | + "user_view_type": "public" |
| 233 | + } |
| 234 | + }, |
| 235 | + { |
| 236 | + "author_association": "MEMBER", |
| 237 | + "body": "> If `--hi-b-white` is replaced with site's default foreground (`#a9d5c4`), here is how it looks:\n\nThat is a nice stop-gap 👍 \n\n\n\n> But if redesign is in order, then using Neovim's own default color scheme for the whole site might be the way to go 🤔\n\nEventually. Probably should migrate away from jekyll first. ", |
| 238 | + "created_at": "2025-10-07T20:21:33Z", |
| 239 | + "html_url": "https://github.com/neovim/neovim.github.io/issues/388#issuecomment-3378578792", |
| 240 | + "id": 3378578792, |
| 241 | + "issue_url": "https://api.github.com/repos/neovim/neovim.github.io/issues/388", |
| 242 | + "node_id": "IC_kwDOAQSZx87JYQVo", |
| 243 | + "performed_via_github_app": null, |
| 244 | + "reactions": { |
| 245 | + "+1": 0, |
| 246 | + "-1": 0, |
| 247 | + "confused": 0, |
| 248 | + "eyes": 0, |
| 249 | + "heart": 0, |
| 250 | + "hooray": 0, |
| 251 | + "laugh": 0, |
| 252 | + "rocket": 0, |
| 253 | + "total_count": 0, |
| 254 | + "url": "https://api.github.com/repos/neovim/neovim.github.io/issues/comments/3378578792/reactions" |
| 255 | + }, |
| 256 | + "updated_at": "2025-10-07T20:21:33Z", |
| 257 | + "url": "https://api.github.com/repos/neovim/neovim.github.io/issues/comments/3378578792", |
| 258 | + "user": { |
| 259 | + "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", |
| 260 | + "events_url": "https://api.github.com/users/justinmk/events{/privacy}", |
| 261 | + "followers_url": "https://api.github.com/users/justinmk/followers", |
| 262 | + "following_url": "https://api.github.com/users/justinmk/following{/other_user}", |
| 263 | + "gists_url": "https://api.github.com/users/justinmk/gists{/gist_id}", |
| 264 | + "gravatar_id": "", |
| 265 | + "html_url": "https://github.com/justinmk", |
| 266 | + "id": 1359421, |
| 267 | + "login": "justinmk", |
| 268 | + "node_id": "MDQ6VXNlcjEzNTk0MjE=", |
| 269 | + "organizations_url": "https://api.github.com/users/justinmk/orgs", |
| 270 | + "received_events_url": "https://api.github.com/users/justinmk/received_events", |
| 271 | + "repos_url": "https://api.github.com/users/justinmk/repos", |
| 272 | + "site_admin": false, |
| 273 | + "starred_url": "https://api.github.com/users/justinmk/starred{/owner}{/repo}", |
| 274 | + "subscriptions_url": "https://api.github.com/users/justinmk/subscriptions", |
| 275 | + "type": "User", |
| 276 | + "url": "https://api.github.com/users/justinmk", |
| 277 | + "user_view_type": "public" |
| 278 | + } |
54 | 279 | } |
55 | 280 | ], |
56 | | - "comments": 1, |
| 281 | + "comments": 6, |
57 | 282 | "comments_url": "https://api.github.com/repos/neovim/neovim.github.io/issues/388/comments", |
58 | 283 | "created_at": "2025-10-03T22:39:58Z", |
59 | 284 | "events_url": "https://api.github.com/repos/neovim/neovim.github.io/issues/388/events", |
|
95 | 320 | "timeline_url": "https://api.github.com/repos/neovim/neovim.github.io/issues/388/timeline", |
96 | 321 | "title": "codeblock syntax highlighting should match site theme", |
97 | 322 | "type": null, |
98 | | - "updated_at": "2025-10-04T11:01:05Z", |
| 323 | + "updated_at": "2025-10-07T20:21:34Z", |
99 | 324 | "url": "https://api.github.com/repos/neovim/neovim.github.io/issues/388", |
100 | 325 | "user": { |
101 | 326 | "avatar_url": "https://avatars.githubusercontent.com/u/1359421?v=4", |
|
0 commit comments