fix: obfuscated exception message

before:

    ● Node host › can run a command from plugin
      failed request to "nvim_command" (see $NVIM_NODE_LOG_FILE for details, if it was set)
        75 |     request(name, args = []) {
        76 |         // Dummy error, to get stacktrace.
      > 77 |         const error = new Error(`failed request to "${name}" (see $NVIM_NODE_LOG_FILE for details, if it was set)`);
           |                       ^
        78 |         return this.asyncRequest(name, args, error.stack);
        79 |     }
        80 |     _getArgsByPrefix(...args) {
        at NeovimClient.request (../neovim/lib/api/Base.js:77:23)
        at NeovimClient.request (../neovim/lib/api/Neovim.js:355:21)
        at Object.command (__tests__/integration.test.ts:85:16)

after:

    ● Node host › can run a command from plugin
      nvim_command: Vim:E492: Not an editor command: JSHostTestCmd
        67 |             return this[DO_REQUEST](name, args).catch(err => {
        68 |                 // XXX: Get a `*.ts stacktrace. If we re-throw `err` we get a `*.js` trace. tsconfig issue?
      > 69 |                 const newError = new Error(err.message);
           |                                  ^
        70 |                 this.logger.error(`failed request to "%s": %s: %s`, name, newError.name, newError.message);
        71 |                 throw newError;
        72 |             });
        at ../neovim/lib/api/Base.js:69:34
        at Object.<anonymous> (__tests__/integration.test.ts:85:5)

Author: justinmk

packages/neovim/src/api/Base.ts

@@ -73,7 +73,7 @@ export class BaseApi extends EventEmitter {
   [DO_REQUEST] = (name: string, args: any[] = []): Promise<any> =>
     new Promise((resolve, reject) => {
       this.transport.request(name, args, (err: any, res: any) => {
-        this.logger.debug(`response -> neovim.api.${name}: ${res}`);
+        this.logger.debug(`response -> ${name}: ${res}`);
         if (err) {
           reject(new Error(`${name}: ${err[1]}`));
         } else {
@@ -85,19 +85,18 @@ export class BaseApi extends EventEmitter {
   async asyncRequest(
     name: string,
     args: any[] = [],
-    stack: string | undefined = undefined
   ): Promise<any> {
     // `this._isReady` is undefined in ExtType classes (i.e. Buffer, Window, Tabpage)
     // But this is just for Neovim API, since it's possible to call this method from Neovim class
     // before transport is ready.
     // Not possible for ExtType classes since they are only created after transport is ready
     await this._isReady;
 
-    this.logger.debug(`request -> neovim.api.${name}`);
+    this.logger.debug(`request -> ${name}`);
 
     return this[DO_REQUEST](name, args).catch(err => {
+      // XXX: Get a `*.ts stacktrace. If we re-throw `err` we get a `*.js` trace. tsconfig issue?
       const newError = new Error(err.message);
-      newError.stack = stack;
       this.logger.error(
         `failed request to "%s": %s: %s`,
         name,
@@ -109,12 +108,7 @@ export class BaseApi extends EventEmitter {
   }
 
   request(name: string, args: any[] = []): Promise<any> {
-    // Dummy error, to get stacktrace.
-    const error = new Error(
-      `failed request to "${name}" (see $NVIM_NODE_LOG_FILE for details, if it was set)`
-    );
-
-    return this.asyncRequest(name, args, error.stack);
+    return this.asyncRequest(name, args);
   }
 
   _getArgsByPrefix(...args: any[]): any[] {
@@ -169,7 +163,7 @@ export class BaseApi extends EventEmitter {
   // TODO: Is this necessary?
   /** `request` is basically the same except you can choose to wait forpromise to be resolved */
   notify(name: string, args: any[]): void {
-    this.logger.debug(`notify -> neovim.api.${name}`);
+    this.logger.debug(`notify -> ${name}`);
     this.transport.notify(name, args);
   }
 }