Skip to content

Commit 891c9d5

Browse files
committed
ci: only run lint on latest node.js + unix
Problem: [email protected] lint > prettier --check . && eslint --format=unix --ignore-pattern 'packages/example*/**' --ignore-pattern 'packages/neovim/lib/**/*.js' . ESLint: 9.34.0 TypeError: object.split(...).toReversed is not a function at createTraceMap (file:///D:/a/node-client/node-client/node_modules/eslint-plugin-unicorn/rules/utils/global-reference-tracker.js:6:33) at new GlobalReferenceTracker (file:///D:/a/node-client/node-client/node_modules/eslint-plugin-unicorn/rules/utils/global-reference-tracker.js:27:34) at file:///D:/a/node-client/node-client/node_modules/eslint-plugin-unicorn/rules/no-document-cookie.js:8:17 at ModuleJob.run (node:internal/modules/esm/module_job:195:25) Solution: Only run lint task on latest nodejs
1 parent 0114da2 commit 891c9d5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ jobs:
8080
run: npm run build
8181

8282
- name: lint
83-
# Skip on old Node.js, devDependencies use newish JS features.
84-
if: matrix.node != '14'
83+
# Only run lint on latest Node.js, because devDependencies use new JS features.
84+
if: matrix.node == '20' && runner.os != 'Windows'
8585
run: npm run lint
8686

8787
- name: test

0 commit comments

Comments
 (0)