Skip to content

Commit d99ecec

Browse files
build: declare name, version in root package.json #365
I'm trying to build node-client on nix using buildNpmPackages, as nix is migrating away from the old way of building node packages, and I get the following: ``` error: builder for '/nix/store/yp8wvva7jzd0z1p6myafvc7h6j2baiax-neovim-node-client-5.1.0.drv' failed with exit code 1; last 25 log lines: > > > > @neovim/[email protected] build > > tsc --pretty > > > > @neovim/[email protected] build > > babel src --out-dir lib > > Successfully compiled 2 files with Babel (132ms). > Finished npmBuildHook > Running phase: installPhase > Executing npmInstallHook > npm ERR! Invalid package, must have name and version ``` This seems to be solved simply by adding the name/version into package.json.
1 parent 0253672 commit d99ecec

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -221,6 +221,7 @@ Only maintainers of the [neovim NPM package](https://www.npmjs.com/package/neovi
221221
2. Update version. Build and publish the package. Tag the release and push.
222222
```bash
223223
# Choose major/minor/patch as needed.
224+
npm version patch
224225
npm version -w packages/neovim/ patch
225226
git commit -m 'release'
226227
# Note: this copies the top-level README.md/CHANGELOG.md to packages/neovim/.
@@ -231,6 +232,7 @@ Only maintainers of the [neovim NPM package](https://www.npmjs.com/package/neovi
231232
```
232233
3. Post-release tasks:
233234
```bash
235+
npm version --no-git-tag-version prerelease --preid dev
234236
npm version -w packages/neovim/ --no-git-tag-version prerelease --preid dev
235237
git add packages/*/package.json package*.json && git commit -m bump
236238
git push

package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
{
2+
"name": "neovim",
3+
"version": "5.1.1-dev.0",
24
"private": true,
35
"workspaces": [
46
"packages/neovim",

0 commit comments

Comments
 (0)