Fix bugs and log exceptions.

Log error message when no handlers are found.

Change string interpolation type for consistency.

Fixed attempting to `format` before the concatenation completed.

Author: btipling

neovim/msgpack_rpc/session.py

@@ -7,7 +7,8 @@
 import greenlet
 
 logger = logging.getLogger(__name__)
-debug, info, warn = (logger.debug, logger.info, logger.warn,)
+error, debug, info, warn = (logger.error, logger.debug, logger.info,
+                            logger.warn,)
 
 
 class Session(object):
@@ -100,6 +101,7 @@ def on_setup():
             gr.switch()
 
         if self._setup_exception:
+            error('Setup error: {0}'.format(self._setup_exception))
             raise self._setup_exception
 
         # Process all pending requests and notifications

neovim/plugin/host.py

@@ -81,9 +81,10 @@ def _load(self, plugins):
             try:
                 module = imp.load_module(name, file, pathname, description)
             except ImportError:
-                error('Encountered import error loading plugin at %s' % path)
+                error('Encountered import error loading plugin at {0}'.format(
+                    path))
             except Exception as e:
-                error('Error loading plugin at %s %s: %s' % (
+                error('Error loading plugin at {0} {1}: {2}'.format(
                     path, type(e).__name__, e))
             handlers = []
             self._discover_classes(module, handlers, path)
@@ -132,13 +133,13 @@ def _discover_functions(self, obj, handlers, plugin_path):
                 method = '{0}:{1}'.format(plugin_path, method)
             if fn._nvim_rpc_sync:
                 if method in self._request_handlers:
-                    raise Exception('Request handler for "{0}" is ' +
-                                    'already registered'.format(method))
+                    raise Exception(('Request handler for "{0}" is ' +
+                                    'already registered').format(method))
                 self._request_handlers[method] = fn
             else:
                 if method in self._notification_handlers:
-                    raise Exception('Notification handler for "{0}" is ' +
-                                    'already registered'.format(method))
+                    raise Exception(('Notification handler for "{0}" is ' +
+                                    'already registered').format(method))
                 self._notification_handlers[method] = fn
             if hasattr(fn, 'nvim_rpc_spec'):
                 specs.append(fn.nvim_rpc_spec)