Skip to content

Commit aee3116

Browse files
committed
Remove unnecessary _greenlets set from session
References to greenlets are already kept by closures, there's no need to store them explicitly in a set
1 parent 5b6c0c7 commit aee3116

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

neovim/msgpack_rpc/session.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ class Session(object):
2222
def __init__(self, async_session):
2323
"""Wrap `async_session` on a synchronous msgpack-rpc interface."""
2424
self._async_session = async_session
25-
self._greenlets = set()
2625
self._request_cb = self._notification_cb = None
2726
self._pending_messages = deque()
2827
self._is_running = False
@@ -140,12 +139,10 @@ def handler():
140139
args, format_exc())
141140
response.send(repr(err), error=True)
142141
debug('greenlet %s is now dying...', gr)
143-
self._greenlets.remove(gr)
144142

145143
# Create a new greenlet to handle the request
146144
gr = greenlet.greenlet(handler)
147145
debug('received rpc request, greenlet %s will handle it', gr)
148-
self._greenlets.add(gr)
149146
gr.switch()
150147

151148
def _on_notification(self, name, args):
@@ -157,9 +154,7 @@ def handler():
157154
warn("error caught while processing notification '%s %s': %s",
158155
name, args, format_exc())
159156
debug('greenlet %s is now dying...', gr)
160-
self._greenlets.remove(gr)
161157

162158
gr = greenlet.greenlet(handler)
163159
debug('received rpc notification, greenlet %s will handle it', gr)
164-
self._greenlets.add(gr)
165160
gr.switch()

0 commit comments

Comments
 (0)