Improve python API: Rename spawn --> child.

Author: elmart

.travis.yml

@@ -36,7 +36,7 @@ install:
 script:
   - if [ $CI_TARGET = tests ]; then
       ./scripts/run-api-tests.exp "nosetests" "nvim -u NONE";
-      NVIM_SPAWN_ARGV='["nvim", "-u", "NONE", "--embed"]' nosetests;
+      NVIM_CHILD_ARGV='["nvim", "-u", "NONE", "--embed"]' nosetests;
     else
       flake8 neovim;
     fi

neovim/__init__.py

@@ -7,13 +7,13 @@
 import sys
 
 from .api import DecodeHook, Nvim, SessionHook
-from .msgpack_rpc import (socket_session, spawn_session, stdio_session,
+from .msgpack_rpc import (child_session, socket_session, stdio_session,
                           tcp_session)
 from .plugin import (Host, autocmd, command, encoding, function, plugin,
                      rpc_export, shutdown_hook)
 
 
-__all__ = ('tcp_session', 'socket_session', 'stdio_session', 'spawn_session',
+__all__ = ('tcp_session', 'socket_session', 'stdio_session', 'child_session',
            'start_host', 'autocmd', 'command', 'encoding', 'function',
            'plugin', 'rpc_export', 'Host', 'DecodeHook', 'Nvim',
            'SessionHook', 'shutdown_hook', 'attach')
@@ -85,7 +85,7 @@ def attach(session_type, address=None, port=None, path=None, argv=None):
     session = (tcp_session(address, port) if session_type == 'tcp' else
                socket_session(path) if session_type == 'socket' else
                stdio_session() if session_type == 'stdio' else
-               spawn_session(argv) if session_type == 'child'else
+               child_session(argv) if session_type == 'child'else
                None)
 
     if not session:

neovim/msgpack_rpc/__init__.py

@@ -10,7 +10,7 @@
 from .session import Session
 
 
-__all__ = ('tcp_session', 'socket_session', 'stdio_session', 'spawn_session')
+__all__ = ('tcp_session', 'socket_session', 'stdio_session', 'child_session')
 
 
 def session(transport_type='stdio', *args, **kwargs):
@@ -36,6 +36,6 @@ def stdio_session():
     return session('stdio')
 
 
-def spawn_session(argv):
+def child_session(argv):
     """Create a msgpack-rpc session from a new Nvim instance."""
-    return session('spawn', argv)
+    return session('child', argv)

neovim/msgpack_rpc/event_loop/asyncio.py

@@ -89,7 +89,7 @@ def _connect_stdio(self):
         coroutine = self._loop.connect_write_pipe(self._fact, sys.stdout)
         self._loop.run_until_complete(coroutine)
 
-    def _connect_spawn(self, argv):
+    def _connect_child(self, argv):
         coroutine = self._loop.subprocess_exec(self._fact, *argv)
         self._loop.run_until_complete(coroutine)
 

neovim/msgpack_rpc/event_loop/base.py

@@ -30,7 +30,7 @@ class BaseEventLoop(object):
     - `_connect_socket(path)`: Same as tcp, but use a UNIX domain socket or
       or named pipe.
     - `_connect_stdio()`: Use stdin/stdout as the connection to Nvim
-    - `_connect_spawn(argv)`: Use the argument vector `argv` to spawn an
+    - `_connect_child(argv)`: Use the argument vector `argv` to spawn an
       embedded Nvim that has it's stdin/stdout connected to the event loop.
     - `_start_reading()`: Called after any of _connect_* methods. Can be used
       to perform any post-connection setup or validation.
@@ -68,7 +68,7 @@ def __init__(self, transport_type, *args):
         Traceback (most recent call last):
             ...
         AttributeError: 'BaseEventLoop' object has no attribute '_init'
-        >>> BaseEventLoop('spawn', ['nvim', '--embed', '-u', 'NONE'])
+        >>> BaseEventLoop('child', ['nvim', '--embed', '-u', 'NONE'])
         Traceback (most recent call last):
             ...
         AttributeError: 'BaseEventLoop' object has no attribute '_init'
@@ -101,10 +101,10 @@ def connect_stdio(self):
         info('Preparing stdin/stdout for streaming data')
         self._connect_stdio()
 
-    def connect_spawn(self, argv):
-        """Connect a new Nvim instance. Delegated to `_connect_spawn`."""
+    def connect_child(self, argv):
+        """Connect a new Nvim instance. Delegated to `_connect_child`."""
         info('Spawning a new nvim instance')
-        self._connect_spawn(argv)
+        self._connect_child(argv)
 
     def send(self, data):
         """Queue `data` for sending to Nvim."""

neovim/msgpack_rpc/event_loop/uv.py

@@ -63,7 +63,7 @@ def _connect_stdio(self):
         self._write_stream = pyuv.Pipe(self._loop)
         self._write_stream.open(sys.stdout.fileno())
 
-    def _connect_spawn(self, argv):
+    def _connect_child(self, argv):
         self._write_stream = pyuv.Pipe(self._loop)
         self._read_stream = pyuv.Pipe(self._loop)
         self._error_stream = pyuv.Pipe(self._loop)

test/common.py

@@ -9,9 +9,9 @@
 
 session = None
 vim = None
-if 'NVIM_SPAWN_ARGV' in os.environ:
-    argv = json.loads(os.environ['NVIM_SPAWN_ARGV'])
-    session = neovim.spawn_session(argv)
+if 'NVIM_CHILD_ARGV' in os.environ:
+    argv = json.loads(os.environ['NVIM_CHILD_ARGV'])
+    session = neovim.child_session(argv)
 else:
     session = neovim.socket_session(os.environ['NVIM_LISTEN_ADDRESS'])