release 9.1.6

Signed-off-by: neo <1100909+neowu@users.noreply.github.com>

Author: neowu

CHANGELOG.md

@@ -1,14 +1,15 @@
 ## Change log
 
-### 9.1.6-b0 (2/10/2025 - )
+### 9.1.6 (2/10/2025 - 2/25/2025)
 
 * http_client: tweak sse checking
 * undertow: updated to 2.3.18.Final
   > due to vulnerability of old versions, has to update to latest despite potential memory consumption is higher
 * sse: support method PUT/POST with body
 * sse: channel.close() now closes sse connection gracefully
 * sse: change retry instruction to 5s
-  > in cloud env, we set backend timeout to around 620s, and let client (js) reconnect every 600s
+  > in cloud env, backend timeout is set to 600s
+* sse: channel.send() returns if sent successfully
 
 ### 9.1.5 (11/11/2024 - 01/22/2025)
 

build.gradle.kts

@@ -7,7 +7,7 @@ apply(plugin = "project")
 
 subprojects {
     group = "core.framework"
-    version = "9.1.6-b1"
+    version = "9.1.6"
 }
 
 val elasticVersion = "8.15.0"

core-ng/src/main/java/core/framework/internal/web/sse/ChannelImpl.java

@@ -51,19 +51,20 @@ class ChannelImpl<T> implements java.nio.channels.Channel, Channel<T> {
     }
 
     @Override
-    public void send(String id, T event) {
+    public boolean send(String id, T event) {
         String data = builder.build(id, event);
-        send(data);
+        return send(data);
     }
 
-    void send(String data) {
-        if (closed) return;
+    boolean send(String data) {
+        if (closed) return false;
 
         var watch = new StopWatch();
         try {
             queue.add(Strings.bytes(data));
             lastSentTime = System.nanoTime();
             sink.getIoThread().execute(() -> writeListener.handleEvent(sink));
+            return true;
         } finally {
             long elapsed = watch.elapsed();
             ActionLogContext.track("sse", elapsed, 0, data.length());

core-ng/src/main/java/core/framework/internal/web/sse/ServerSentEventHandler.java

@@ -28,7 +28,9 @@
 import java.util.Map;
 
 public class ServerSentEventHandler implements HttpHandler {
-    static final long MAX_PROCESS_TIME_IN_NANO = Duration.ofSeconds(300).toNanos();    // persistent connection, use longer max process time, and background task keeps pinging the connection
+    // persistent connection, use longer max process time
+    // though LB backend timeout is to 600s, for long time sse, it should be processed via message queue
+    static final long MAX_PROCESS_TIME_IN_NANO = Duration.ofSeconds(300).toNanos();
 
     private static final HttpString LAST_EVENT_ID = new HttpString("Last-Event-ID");
     private final Logger logger = LoggerFactory.getLogger(ServerSentEventHandler.class);

core-ng/src/main/java/core/framework/web/sse/Channel.java

@@ -1,7 +1,8 @@
 package core.framework.web.sse;
 
 public interface Channel<T> {
-    void send(String id, T event);
+    // return true if event is queued, return false if channel is closed
+    boolean send(String id, T event);
 
     default void send(T event) {
         send(null, event);

core-ng/src/test/java/core/framework/internal/web/sse/ServerSentEventContextImplTest.java

@@ -8,7 +8,7 @@
 import java.util.List;
 
 import static org.assertj.core.api.Assertions.assertThat;
-import static org.mockito.Mockito.doNothing;
+import static org.mockito.Mockito.doReturn;
 import static org.mockito.Mockito.spy;
 import static org.mockito.Mockito.verify;
 
@@ -71,7 +71,7 @@ void keepAlive() {
         context.keepAlive();
 
         channel.lastSentTime = 0;
-        doNothing().when(channel).send(":\n");
+        doReturn(Boolean.TRUE).when(channel).send(":\n");
         context.keepAlive();
         verify(channel, Mockito.times(1)).send(":\n");
     }