tweak query inspector

Signed-off-by: neo <1100909+neowu@users.noreply.github.com>

Author: neowu

core-ng/src/main/java/core/framework/internal/db/inspector/MySQLQueryAnalyzer.java

@@ -30,12 +30,12 @@ public QueryPlan explain(String sql, Object[] params) {
 
     boolean isEfficient(Explain explain) {
         if ("ALL".equals(explain.type)) {
-            if (explain.rows != null && explain.rows > 2000) {
+            if (explain.rowsGreaterThan(2000)) {
                 return false;
             }
         }
-        if (explain.extra != null) {
-            if (explain.extra.contains("Using temporary") || explain.extra.contains("Using filesort")) {
+        if (explain.extra != null && (explain.extra.contains("Using temporary") || explain.extra.contains("Using filesort"))) {
+            if (explain.rowsGreaterThan(10_000)) {
                 return false;
             }
         }
@@ -76,6 +76,10 @@ static class Explain {
         Long rows;
         String filtered;
         String extra;
+
+        boolean rowsGreaterThan(long threshold) {
+            return rows != null && rows > threshold;
+        }
     }
 
     static class ExplainRowMapper implements RowMapper<Explain> {

core-ng/src/test/java/core/framework/internal/db/inspector/MySQLQueryAnalyzerTest.java

@@ -31,14 +31,20 @@ void format() {
 
     @Test
     void isEfficient() {
-        var explain = parse("1|SIMPLE|t1||ALL|idx_col1_col2|idx_col1_col2|13|const|100||Using where; Using index; Using filesort");
+        var explain = parse("1|SIMPLE|t1||ALL|idx_col1_col2|idx_col1_col2|13|const|3000||Using where; Using index; Using filesort");
         assertThat(analyzer.isEfficient(explain)).isFalse();
 
         explain = parse("1|SIMPLE|t1||ALL|idx_col1_col2|idx_col1_col2|13|const|100||Using where; Using index");
         assertThat(analyzer.isEfficient(explain)).isTrue(); // scan less than 2000 rows
 
         explain = parse("1|SIMPLE|daily_individual_stats||index_merge|PRIMARY,idx_customer_id|idx_customer_id,PRIMARY|149,149||1|100|Using intersect(idx_customer_id,PRIMARY); Using where");
         assertThat(analyzer.isEfficient(explain)).isTrue();
+
+        explain = parse("1|SIMPLE|role||ALL|||||24|100|Using filesort");
+        assertThat(analyzer.isEfficient(explain)).isTrue();
+
+        explain = parse("1|SIMPLE|stat||range|PRIMARY,idx_customer_id|PRIMARY|3||7942|100.0|Using where; Using temporary; Using filesort");
+        assertThat(analyzer.isEfficient(explain)).isTrue();
     }
 
     // 1|SIMPLE|daily_individual_stats||index_merge|PRIMARY,idx_customer_id|idx_customer_id,PRIMARY|149,149||1|100|Using intersect(idx_customer_id,PRIMARY); Using where