Skip to content

Commit 793d2da

Browse files
committed
minor refactoring
Signed-off-by: neo <1100909+neowu@users.noreply.github.com>
1 parent 95f1775 commit 793d2da

File tree

4 files changed

+9
-2
lines changed

4 files changed

+9
-2
lines changed

TODO.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919

2020
* migrate to opensearch ? or update ES to 9.x
2121

22+
* support hsql postgres dialect, to test postgres specific sql?
23+
2224
### obsoleted
2325

2426
* template, use ByteBuffer[] for performance? (server side template not useful anymore)
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
@NullMarked
2+
package core.framework.test;
3+
4+
import org.jspecify.annotations.NullMarked;

core-ng/src/main/java/core/framework/internal/db/DatabaseImpl.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ public final class DatabaseImpl implements Database {
4242
}
4343

4444
public final Pool<Connection> pool;
45+
public final TransactionManager transactionManager;
46+
4547
final DatabaseOperation operation;
4648
private final Logger logger = LoggerFactory.getLogger(DatabaseImpl.class);
4749
private final Map<Class<?>, RowMapper<?>> rowMappers = new HashMap<>(32);
@@ -50,7 +52,6 @@ public final class DatabaseImpl implements Database {
5052
public @Nullable String password;
5153
public @Nullable CloudAuthProvider authProvider;
5254
public @Nullable IsolationLevel isolationLevel;
53-
public TransactionManager transactionManager;
5455

5556
private @Nullable String url;
5657
private @Nullable Properties driverProperties;

core-ng/src/main/java/core/framework/internal/db/DatabaseOperation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@
3434
*/
3535
public class DatabaseOperation {
3636
final EnumDBMapper enumMapper = new EnumDBMapper();
37-
private final TransactionManager transactionManager;
3837
private final Logger logger = LoggerFactory.getLogger(DatabaseOperation.class);
38+
private final TransactionManager transactionManager;
3939
Dialect dialect;
4040
int queryTimeoutInSeconds;
4141

0 commit comments

Comments
 (0)