Skip to content

Commit 25c75d1

Browse files
committed
Test fetch_experiments_table
1 parent 62e4444 commit 25c75d1

File tree

3 files changed

+37
-6
lines changed

3 files changed

+37
-6
lines changed

tests/e2e/v1/generator.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -248,9 +248,9 @@ def metrics_values(self, name: AttributeName) -> list[tuple[Step, Value]]:
248248
},
249249
metrics={
250250
"series-containing-inf": dict(zip(range(10), [inf, 1, -inf, 3, 4, inf, 6, -inf, 8, 9])),
251-
"series-ending-with-inf": dict(zip(range(10), [1, 2, 3, 4, 5, 6, 7, 8, 9, inf])),
251+
"series-ending-with-inf": dict(zip(range(10), [0, 1, 2, 3, 4, 5, 6, 7, 8, inf])),
252252
"series-containing-nan": dict(zip(range(10), [nan, 1, nan, 3, 4, nan, 6, nan, 8, 9])),
253-
"series-ending-with-nan": dict(zip(range(10), [1, 2, 3, 4, 5, 6, 7, 8, 9, nan])),
253+
"series-ending-with-nan": dict(zip(range(10), [0, 1, 2, 3, 4, 5, 6, 7, 8, nan])),
254254
},
255255
),
256256
]

tests/e2e/v1/test_experiments.py

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
TEST_DATA,
2020
TEST_DATA_VERSION,
2121
)
22+
from tests.e2e.v1.generator import EXP_NAME_INF_NAN_RUN
2223

2324

2425
@pytest.mark.parametrize("sort_direction", ["asc", "desc"])
@@ -312,6 +313,38 @@ def test__fetch_experiments_table_with_attributes_regex_filter_for_metrics(
312313
assert df[expected.columns].columns.equals(expected.columns)
313314

314315

316+
@pytest.mark.skip(reason="Skipped until inf/nan handling is enabled in the backend")
317+
def test__fetch_experiments_table_nan_inf(new_project_id):
318+
df = fetch_experiments_table(
319+
project=new_project_id,
320+
experiments=[EXP_NAME_INF_NAN_RUN],
321+
attributes=[
322+
"inf-float",
323+
"nan-float",
324+
"neg-inf-float",
325+
"series-containing-inf",
326+
"series-ending-with-inf",
327+
"series-containing-nan",
328+
"series-ending-with-nan",
329+
],
330+
)
331+
332+
expected = pd.DataFrame(
333+
{
334+
"experiment": [EXP_NAME_INF_NAN_RUN],
335+
"inf-float": [float("inf")],
336+
"nan-float": [float("nan")],
337+
"neg-inf-float": [float("-inf")],
338+
"series-containing-inf": [9.0],
339+
"series-ending-with-inf": [float("inf")],
340+
"series-containing-nan": [9.0],
341+
"series-ending-with-nan": [float("nan")],
342+
}
343+
).set_index("experiment", drop=True)
344+
assert df.shape == (1, 7)
345+
pd.testing.assert_frame_equal(df[expected.columns], expected)
346+
347+
315348
@pytest.mark.parametrize(
316349
"arg_experiments, expected_subset",
317350
[

tests/e2e/v1/test_fetch_metrics.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,6 @@
1212
import numpy as np
1313
import pandas as pd
1414
import pytest
15-
from e2e.v1.generator import (
16-
RUN_BY_ID,
17-
RUN_ID_INF_NAN_RUN,
18-
)
1915

2016
from neptune_query import fetch_metrics
2117
from neptune_query.filters import (
@@ -41,6 +37,8 @@
4137
from tests.e2e.v1.generator import (
4238
EXP_NAME_INF_NAN_RUN,
4339
MULT_EXPERIMENT_HISTORY_EXP_2,
40+
RUN_BY_ID,
41+
RUN_ID_INF_NAN_RUN,
4442
timestamp_for_step,
4543
)
4644

0 commit comments

Comments
 (0)